| Message ID | 1500908825-31658-3-git-send-email-patrice.chotard@st.com |
|---|---|
| State | Accepted |
| Commit | 623b7aca1f82bf1dee089c77f9a1020e80abaccc |
| Delegated to: | Marek Vasut |
| Headers | show |
On 24 July 2017 at 09:07, <patrice.chotard@st.com> wrote: > From: Patrice Chotard <patrice.chotard@st.com> > > Add CONFIG_DM_USB flag to avoid following compilation errors > detected by buildman : > +drivers/usb/host/built-in.o: In function `xhci_dwc3_remove': > +drivers/usb/host/xhci-dwc3.c:168: undefined reference to `xhci_deregister' > +drivers/usb/host/built-in.o: In function `xhci_dwc3_probe': > +drivers/usb/host/xhci-dwc3.c:145: undefined reference to `usb_get_dr_mode' > +drivers/usb/host/xhci-dwc3.c:152: undefined reference to `xhci_register' > > introduced by patch d5c3f014da3 "usb: host: xhci-dwc3: Convert driver to DM" > > Signed-off-by: Patrice Chotard <patrice.chotard@st.com> > Reported-by: Ran Wang <ran.wang_1@nxp.com> > --- > drivers/usb/host/xhci-dwc3.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Simon Glass <sjg@chromium.org>
On 08/06/2017 07:15 AM, Simon Glass wrote: > On 24 July 2017 at 09:07, <patrice.chotard@st.com> wrote: >> From: Patrice Chotard <patrice.chotard@st.com> >> >> Add CONFIG_DM_USB flag to avoid following compilation errors >> detected by buildman : >> +drivers/usb/host/built-in.o: In function `xhci_dwc3_remove': >> +drivers/usb/host/xhci-dwc3.c:168: undefined reference to `xhci_deregister' >> +drivers/usb/host/built-in.o: In function `xhci_dwc3_probe': >> +drivers/usb/host/xhci-dwc3.c:145: undefined reference to `usb_get_dr_mode' >> +drivers/usb/host/xhci-dwc3.c:152: undefined reference to `xhci_register' >> >> introduced by patch d5c3f014da3 "usb: host: xhci-dwc3: Convert driver to DM" >> >> Signed-off-by: Patrice Chotard <patrice.chotard@st.com> >> Reported-by: Ran Wang <ran.wang_1@nxp.com> >> --- >> drivers/usb/host/xhci-dwc3.c | 2 ++ >> 1 file changed, 2 insertions(+) > > Reviewed-by: Simon Glass <sjg@chromium.org> > Um, this patch was applied like two weeks ago. Is this some automated botmail ... reviewman ? :)
Hi Marek, On 6 August 2017 at 13:17, Marek Vasut <marex@denx.de> wrote: > On 08/06/2017 07:15 AM, Simon Glass wrote: >> On 24 July 2017 at 09:07, <patrice.chotard@st.com> wrote: >>> From: Patrice Chotard <patrice.chotard@st.com> >>> >>> Add CONFIG_DM_USB flag to avoid following compilation errors >>> detected by buildman : >>> +drivers/usb/host/built-in.o: In function `xhci_dwc3_remove': >>> +drivers/usb/host/xhci-dwc3.c:168: undefined reference to `xhci_deregister' >>> +drivers/usb/host/built-in.o: In function `xhci_dwc3_probe': >>> +drivers/usb/host/xhci-dwc3.c:145: undefined reference to `usb_get_dr_mode' >>> +drivers/usb/host/xhci-dwc3.c:152: undefined reference to `xhci_register' >>> >>> introduced by patch d5c3f014da3 "usb: host: xhci-dwc3: Convert driver to DM" >>> >>> Signed-off-by: Patrice Chotard <patrice.chotard@st.com> >>> Reported-by: Ran Wang <ran.wang_1@nxp.com> >>> --- >>> drivers/usb/host/xhci-dwc3.c | 2 ++ >>> 1 file changed, 2 insertions(+) >> >> Reviewed-by: Simon Glass <sjg@chromium.org> >> > Um, this patch was applied like two weeks ago. Is this some automated > botmail ... reviewman ? :) There is no mention of it being applied on this thread, so it looked like an open patch to me. Regards, Simon
diff --git a/drivers/usb/host/xhci-dwc3.c b/drivers/usb/host/xhci-dwc3.c index 374fe74..541a785 100644 --- a/drivers/usb/host/xhci-dwc3.c +++ b/drivers/usb/host/xhci-dwc3.c @@ -111,6 +111,7 @@ void dwc3_set_fladj(struct dwc3 *dwc3_reg, u32 val) GFLADJ_30MHZ(val)); } +#ifdef CONFIG_DM_USB static int xhci_dwc3_probe(struct udevice *dev) { struct xhci_dwc3_platdata *plat = dev_get_platdata(dev); @@ -184,3 +185,4 @@ U_BOOT_DRIVER(xhci_dwc3) = { .platdata_auto_alloc_size = sizeof(struct xhci_dwc3_platdata), .flags = DM_FLAG_ALLOC_PRIV_DMA, }; +#endif