diff mbox

[U-Boot,1/4] rockchip: dts: correct vdd_log setting for firefly-rk3399

Message ID 1500465263-25544-1-git-send-email-kever.yang@rock-chips.com
State Accepted
Commit 7ba3182e2d92190b7512db35ecda71970a206207
Delegated to: Philipp Tomsich
Headers show

Commit Message

Kever Yang July 19, 2017, 11:54 a.m. UTC
Add regulator-init-microvolt for driver to init the regulator,
and the min output value is not 800000mV for the PWM2 io domain has
changed to VCC3V0 instead of VCC1V8 in rockchip evb, we need to
correct it with the value measured when PWM2 output HIGH.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
---

 arch/arm/dts/rk3399-firefly.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Philipp Tomsich July 19, 2017, 12:42 p.m. UTC | #1
> Add regulator-init-microvolt for driver to init the regulator,
> and the min output value is not 800000mV for the PWM2 io domain has
> changed to VCC3V0 instead of VCC1V8 in rockchip evb, we need to
> correct it with the value measured when PWM2 output HIGH.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
> 
>  arch/arm/dts/rk3399-firefly.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich July 26, 2017, 4:52 p.m. UTC | #2
> Add regulator-init-microvolt for driver to init the regulator,
> and the min output value is not 800000mV for the PWM2 io domain has
> changed to VCC3V0 instead of VCC1V8 in rockchip evb, we need to
> correct it with the value measured when PWM2 output HIGH.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  arch/arm/dts/rk3399-firefly.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich July 27, 2017, 8:32 a.m. UTC | #3
> Add regulator-init-microvolt for driver to init the regulator,
> and the min output value is not 800000mV for the PWM2 io domain has
> changed to VCC3V0 instead of VCC1V8 in rockchip evb, we need to
> correct it with the value measured when PWM2 output HIGH.
> 
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  arch/arm/dts/rk3399-firefly.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 

Applied to u-boot-rockchip, thanks!
Simon Glass July 27, 2017, 3:13 p.m. UTC | #4
On 19 July 2017 at 05:54, Kever Yang <kever.yang@rock-chips.com> wrote:
> Add regulator-init-microvolt for driver to init the regulator,
> and the min output value is not 800000mV for the PWM2 io domain has
> changed to VCC3V0 instead of VCC1V8 in rockchip evb, we need to
> correct it with the value measured when PWM2 output HIGH.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> ---
>
>  arch/arm/dts/rk3399-firefly.dts | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
diff mbox

Patch

diff --git a/arch/arm/dts/rk3399-firefly.dts b/arch/arm/dts/rk3399-firefly.dts
index a3e9ddf..3d3f507 100644
--- a/arch/arm/dts/rk3399-firefly.dts
+++ b/arch/arm/dts/rk3399-firefly.dts
@@ -157,8 +157,9 @@ 
 		regulator-name = "vdd_log";
 		regulator-always-on;
 		regulator-boot-on;
-		regulator-min-microvolt = <800000>;
+		regulator-min-microvolt = <430000>;
 		regulator-max-microvolt = <1400000>;
+		regulator-init-microvolt = <950000>;
 	};
 
 	vccadc_ref: vccadc-ref {