| Message ID | 1500042134-37244-2-git-send-email-philipp.tomsich@theobroma-systems.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Marek Vasut |
| Headers | show |
On 07/14/2017 04:22 PM, Philipp Tomsich wrote: > In order to easily model a that CMD_USB_MASS_STORAGE implies having > USB_FUNCTION_MASS_STORAGE enabled, we first need to migrate > USB_FUNCTION_MASS_STORAGE to Kconfig. > > Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> > --- > > drivers/usb/gadget/Kconfig | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > index 261ed12..1c4a4f2 100644 > --- a/drivers/usb/gadget/Kconfig > +++ b/drivers/usb/gadget/Kconfig > @@ -34,6 +34,15 @@ menuconfig USB_GADGET > peripheral/device side bus controller, and a "gadget driver" for > your peripheral protocol. > > +config USB_FUNCTION_MASS_STORAGE > + bool "USB mass-storage class implementation" > + help The alignment of "help" and "bool" above looks weird > + The Mass Storage Function acts as a USB Mass Storage device > + appearing to the host as a disk drive or as a CD-ROM drive. > + > + This is required (and implied) by the USB mass-storage emulation > + command ('ums'). > + > if USB_GADGET > > config USB_GADGET_ATMEL_USBA >
> On 14 Jul 2017, at 16:48, Marek Vasut <marex@denx.de> wrote: > > On 07/14/2017 04:22 PM, Philipp Tomsich wrote: >> In order to easily model a that CMD_USB_MASS_STORAGE implies having >> USB_FUNCTION_MASS_STORAGE enabled, we first need to migrate >> USB_FUNCTION_MASS_STORAGE to Kconfig. >> >> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> >> --- >> >> drivers/usb/gadget/Kconfig | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig >> index 261ed12..1c4a4f2 100644 >> --- a/drivers/usb/gadget/Kconfig >> +++ b/drivers/usb/gadget/Kconfig >> @@ -34,6 +34,15 @@ menuconfig USB_GADGET >> peripheral/device side bus controller, and a "gadget driver" for >> your peripheral protocol. >> >> +config USB_FUNCTION_MASS_STORAGE >> + bool "USB mass-storage class implementation" >> + help > > The alignment of "help" and "bool" above looks weird Tabs vs. Spaces, it appears. Do you want me to send a v2? > >> + The Mass Storage Function acts as a USB Mass Storage device >> + appearing to the host as a disk drive or as a CD-ROM drive. >> + >> + This is required (and implied) by the USB mass-storage emulation >> + command ('ums'). >> + >> if USB_GADGET >> >> config USB_GADGET_ATMEL_USBA >> > > > -- > Best regards, > Marek Vasut
On 07/14/2017 04:55 PM, Dr. Philipp Tomsich wrote: > >> On 14 Jul 2017, at 16:48, Marek Vasut <marex@denx.de> wrote: >> >> On 07/14/2017 04:22 PM, Philipp Tomsich wrote: >>> In order to easily model a that CMD_USB_MASS_STORAGE implies having >>> USB_FUNCTION_MASS_STORAGE enabled, we first need to migrate >>> USB_FUNCTION_MASS_STORAGE to Kconfig. >>> >>> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> >>> --- >>> >>> drivers/usb/gadget/Kconfig | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig >>> index 261ed12..1c4a4f2 100644 >>> --- a/drivers/usb/gadget/Kconfig >>> +++ b/drivers/usb/gadget/Kconfig >>> @@ -34,6 +34,15 @@ menuconfig USB_GADGET >>> peripheral/device side bus controller, and a "gadget driver" for >>> your peripheral protocol. >>> >>> +config USB_FUNCTION_MASS_STORAGE >>> + bool "USB mass-storage class implementation" >>> + help >> >> The alignment of "help" and "bool" above looks weird > > Tabs vs. Spaces, it appears. > Do you want me to send a v2? Yes >> >>> + The Mass Storage Function acts as a USB Mass Storage device >>> + appearing to the host as a disk drive or as a CD-ROM drive. >>> + >>> + This is required (and implied) by the USB mass-storage emulation >>> + command ('ums'). >>> + >>> if USB_GADGET >>> >>> config USB_GADGET_ATMEL_USBA >>> >> >> >> -- >> Best regards, >> Marek Vasut >
diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig index 261ed12..1c4a4f2 100644 --- a/drivers/usb/gadget/Kconfig +++ b/drivers/usb/gadget/Kconfig @@ -34,6 +34,15 @@ menuconfig USB_GADGET peripheral/device side bus controller, and a "gadget driver" for your peripheral protocol. +config USB_FUNCTION_MASS_STORAGE + bool "USB mass-storage class implementation" + help + The Mass Storage Function acts as a USB Mass Storage device + appearing to the host as a disk drive or as a CD-ROM drive. + + This is required (and implied) by the USB mass-storage emulation + command ('ums'). + if USB_GADGET config USB_GADGET_ATMEL_USBA
In order to easily model a that CMD_USB_MASS_STORAGE implies having USB_FUNCTION_MASS_STORAGE enabled, we first need to migrate USB_FUNCTION_MASS_STORAGE to Kconfig. Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com> --- drivers/usb/gadget/Kconfig | 9 +++++++++ 1 file changed, 9 insertions(+)