diff mbox

[U-Boot] rkcommon.c: Remove unused rkcommon_spi_to_offset

Message ID 1496975605-5747-1-git-send-email-trini@konsulko.com
State Accepted
Commit beca2901fd09f265b6a9b521d31276f93404cd6a
Delegated to: Philipp Tomsich
Headers show

Commit Message

Tom Rini June 9, 2017, 2:33 a.m. UTC
This function is unused, remove.  Reported by clang-3.8.

Fixes: a1c29d4b43dc ("rockchip: mkimage: set init_boot_size to avoid ...")
Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 tools/rkcommon.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Philipp Tomsich June 12, 2017, 10:51 a.m. UTC | #1
On Thu, 8 Jun 2017, Tom Rini wrote:

> This function is unused, remove.  Reported by clang-3.8.
>
> Fixes: a1c29d4b43dc ("rockchip: mkimage: set init_boot_size to avoid ...")
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
> tools/rkcommon.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/tools/rkcommon.c b/tools/rkcommon.c
> index fd95abc79aed..a29dc6a5453a 100644
> --- a/tools/rkcommon.c
> +++ b/tools/rkcommon.c
> @@ -226,11 +226,6 @@ static inline unsigned rkcommon_offset_to_spi(unsigned offset)
> 	return ((offset & ~0x7ff) << 1) + (offset & 0x7ff);
> }
>
> -static inline unsigned rkcommon_spi_to_offset(unsigned offset)
> -{
> -	return ((offset & ~0x7ff) >> 1) + (offset & 0x7ff);
> -}
> -
> static int rkcommon_parse_header(const void *buf, struct header0_info *header0,
> 				 struct spl_info **spl_info)
> {
>

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
Philipp Tomsich June 21, 2017, 4:13 p.m. UTC | #2
On Thu, 8 Jun 2017, Tom Rini wrote:

> This function is unused, remove.  Reported by clang-3.8.
>
> Fixes: a1c29d4b43dc ("rockchip: mkimage: set init_boot_size to avoid ...")
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---

Applied to u-boot-rockchip/master, thanks!
diff mbox

Patch

diff --git a/tools/rkcommon.c b/tools/rkcommon.c
index fd95abc79aed..a29dc6a5453a 100644
--- a/tools/rkcommon.c
+++ b/tools/rkcommon.c
@@ -226,11 +226,6 @@  static inline unsigned rkcommon_offset_to_spi(unsigned offset)
 	return ((offset & ~0x7ff) << 1) + (offset & 0x7ff);
 }
 
-static inline unsigned rkcommon_spi_to_offset(unsigned offset)
-{
-	return ((offset & ~0x7ff) >> 1) + (offset & 0x7ff);
-}
-
 static int rkcommon_parse_header(const void *buf, struct header0_info *header0,
 				 struct spl_info **spl_info)
 {