diff mbox

[U-Boot,1/5] rockchip: mkimage: Add support for RV1108

Message ID 1496311111-10057-1-git-send-email-andy.yan@rock-chips.com
State Accepted
Commit 79fa157387c4ce874bf84a145aaf5d8a209cadc3
Delegated to: Simon Glass
Headers show

Commit Message

Andy Yan June 1, 2017, 9:58 a.m. UTC
Add support to mkimage for rv1108 soc, the max
spl code size for rv1108 is 6kb, and the spl
code should be packed by rksd, wether boot from
emmc or spi nor flash.

Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
---

 tools/rkcommon.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Philipp Tomsich June 1, 2017, 10:39 a.m. UTC | #1
> On 01 Jun 2017, at 11:58, Andy Yan <andy.yan@rock-chips.com> wrote:
> 
> Add support to mkimage for rv1108 soc, the max
> spl code size for rv1108 is 6kb, and the spl
> code should be packed by rksd, wether boot from
> emmc or spi nor flash.
> 
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
> 
> tools/rkcommon.c | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/tools/rkcommon.c b/tools/rkcommon.c
> index 42547aa..fd95abc 100644
> --- a/tools/rkcommon.c
> +++ b/tools/rkcommon.c
> @@ -77,6 +77,7 @@ static struct spl_info spl_infos[] = {
> 	{ "rk3288", "RK32", 0x8000, false, false },
> 	{ "rk3328", "RK32", 0x8000 - 0x1000, false, false },
> 	{ "rk3399", "RK33", 0x20000, false, true },
> +	{ "rv1108", "RK11", 0x1800, false, false},

So the RV1108 does not use the BOOT0 hook… now our previous discussion
from this morning makes sense ;-)

Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>

> };
> 
> static unsigned char rc4_key[16] = {
> -- 
> 2.7.4
> 
>
Simon Glass June 2, 2017, 2:55 a.m. UTC | #2
On 1 June 2017 at 03:58, Andy Yan <andy.yan@rock-chips.com> wrote:
> Add support to mkimage for rv1108 soc, the max
> spl code size for rv1108 is 6kb, and the spl
> code should be packed by rksd, wether boot from
> emmc or spi nor flash.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
>  tools/rkcommon.c | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>
Simon Glass June 5, 2017, 9:31 p.m. UTC | #3
On 1 June 2017 at 03:58, Andy Yan <andy.yan@rock-chips.com> wrote:
> Add support to mkimage for rv1108 soc, the max
> spl code size for rv1108 is 6kb, and the spl
> code should be packed by rksd, wether boot from
> emmc or spi nor flash.
>
> Signed-off-by: Andy Yan <andy.yan@rock-chips.com>
> ---
>
>  tools/rkcommon.c | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot-rockchip, thanks!
diff mbox

Patch

diff --git a/tools/rkcommon.c b/tools/rkcommon.c
index 42547aa..fd95abc 100644
--- a/tools/rkcommon.c
+++ b/tools/rkcommon.c
@@ -77,6 +77,7 @@  static struct spl_info spl_infos[] = {
 	{ "rk3288", "RK32", 0x8000, false, false },
 	{ "rk3328", "RK32", 0x8000 - 0x1000, false, false },
 	{ "rk3399", "RK33", 0x20000, false, true },
+	{ "rv1108", "RK11", 0x1800, false, false},
 };
 
 static unsigned char rc4_key[16] = {