diff mbox

[U-Boot,v2,2/6] disk_partition: introduce macros for description string lengths

Message ID 1496076573-14495-3-git-send-email-alison@peloton-tech.com
State Superseded
Delegated to: Tom Rini
Headers show

Commit Message

Alison Chaiken May 29, 2017, 4:49 p.m. UTC 
From: Alison Chaiken <alison@she-devel.com>

Signed-off-by: Alison Chaiken <alison@peloton-tech.com>
---
 include/part.h | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Lukasz Majewski May 31, 2017, 7:37 a.m. UTC | #1 
Hi Alison,

> From: Alison Chaiken <alison@she-devel.com>
> 
> Signed-off-by: Alison Chaiken <alison@peloton-tech.com>
> ---
>  include/part.h | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/include/part.h b/include/part.h
> index 6ace09f..87b1111 100644
> --- a/include/part.h
> +++ b/include/part.h
> @@ -47,12 +47,15 @@ struct block_drvr {
>  #define DEV_TYPE_CDROM		0x05	/* CD-ROM */
>  #define DEV_TYPE_OPDISK		0x07	/* optical disk */
>  
> +#define PART_NAME_LEN 32
> +#define PART_TYPE_LEN 32
> +
>  typedef struct disk_partition {
>  	lbaint_t	start;	/* # of first block in
> partition	*/ lbaint_t	size;	/* number of blocks
> in partition	*/ ulong	blksz;		/* block
> size in bytes			*/
> -	uchar	name[32];	/* partition
> name			*/
> -	uchar	type[32];	/* string type
> description		*/
> +	uchar	name[PART_NAME_LEN];	/* partition
> name			*/
> +	uchar	type[PART_TYPE_LEN];	/* string type
> description		*/ int	bootable;	/*
> Active/Bootable flag is set		*/ #if
> CONFIG_IS_ENABLED(PARTITION_UUIDS) char	uuid[UUID_STR_LEN +
> 1];	/* filesystem UUID as string, if exists	*/


Acked-by: Lukasz Majewski <lukma@denx.de>

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Tom Rini May 31, 2017, 1:50 p.m. UTC | #2 
On Mon, May 29, 2017 at 09:49:29AM -0700, alison@peloton-tech.com wrote:

> From: Alison Chaiken <alison@she-devel.com>
> 
> Signed-off-by: Alison Chaiken <alison@peloton-tech.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
diff mbox

Patch

diff --git a/include/part.h b/include/part.h
index 6ace09f..87b1111 100644
--- a/include/part.h
+++ b/include/part.h
@@ -47,12 +47,15 @@  struct block_drvr {
 #define DEV_TYPE_CDROM		0x05	/* CD-ROM */
 #define DEV_TYPE_OPDISK		0x07	/* optical disk */
 
+#define PART_NAME_LEN 32
+#define PART_TYPE_LEN 32
+
 typedef struct disk_partition {
 	lbaint_t	start;	/* # of first block in partition	*/
 	lbaint_t	size;	/* number of blocks in partition	*/
 	ulong	blksz;		/* block size in bytes			*/
-	uchar	name[32];	/* partition name			*/
-	uchar	type[32];	/* string type description		*/
+	uchar	name[PART_NAME_LEN];	/* partition name			*/
+	uchar	type[PART_TYPE_LEN];	/* string type description		*/
 	int	bootable;	/* Active/Bootable flag is set		*/
 #if CONFIG_IS_ENABLED(PARTITION_UUIDS)
 	char	uuid[UUID_STR_LEN + 1];	/* filesystem UUID as string, if exists	*/