diff mbox

[U-Boot] LS1012A: change the size of flash

Message ID 1493112099-30909-2-git-send-email-suresh.gupta@nxp.com
State Accepted
Commit 5e3f763a4b00b6ca99e3e7e30544c78a8cb05f20
Delegated to: York Sun
Headers show

Commit Message

Suresh Gupta April 25, 2017, 9:21 a.m. UTC
LS1012A has S25FS512S flash of 64M size

Signed-off-by: Suresh Gupta <suresh.gupta@nxp.com>
---
 include/configs/ls1012a_common.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

York Sun May 23, 2017, 4:20 p.m. UTC | #1
On 04/25/2017 02:20 AM, Suresh Gupta wrote:
> LS1012A has S25FS512S flash of 64M size
>
> Signed-off-by: Suresh Gupta <suresh.gupta@nxp.com>
> ---
>  include/configs/ls1012a_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/ls1012a_common.h b/include/configs/ls1012a_common.h
> index 0db926f..861cbc3 100644
> --- a/include/configs/ls1012a_common.h
> +++ b/include/configs/ls1012a_common.h
> @@ -56,7 +56,7 @@
>  #define QSPI0_AMBA_BASE		0x40000000
>  #define CONFIG_SPI_FLASH_SPANSION
>
> -#define FSL_QSPI_FLASH_SIZE		(1 << 24)
> +#define FSL_QSPI_FLASH_SIZE		SZ_64M
>  #define FSL_QSPI_FLASH_NUM		2
>
>  /*
>

Suresh,

LS1012A doesn't have any flash built-in. Do you mean all boards 
supporting LS1012A have the same flash chip with 64MB in size? Please 
clarify.

York
Suresh Gupta May 24, 2017, 5:52 a.m. UTC | #2
> -----Original Message-----
> From: york sun
> Sent: Tuesday, May 23, 2017 9:50 PM
> To: Suresh Gupta <suresh.gupta@nxp.com>; u-boot@lists.denx.de
> Cc: jagan@openedev.com
> Subject: Re: [PATCH] LS1012A: change the size of flash
> 
> On 04/25/2017 02:20 AM, Suresh Gupta wrote:
> > LS1012A has S25FS512S flash of 64M size
> >
> > Signed-off-by: Suresh Gupta <suresh.gupta@nxp.com>
> > ---
> >  include/configs/ls1012a_common.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/ls1012a_common.h
> > b/include/configs/ls1012a_common.h
> > index 0db926f..861cbc3 100644
> > --- a/include/configs/ls1012a_common.h
> > +++ b/include/configs/ls1012a_common.h
> > @@ -56,7 +56,7 @@
> >  #define QSPI0_AMBA_BASE		0x40000000
> >  #define CONFIG_SPI_FLASH_SPANSION
> >
> > -#define FSL_QSPI_FLASH_SIZE		(1 << 24)
> > +#define FSL_QSPI_FLASH_SIZE		SZ_64M
> >  #define FSL_QSPI_FLASH_NUM		2
> >
> >  /*
> >
> 
> Suresh,
> 
> LS1012A doesn't have any flash built-in. Do you mean all boards supporting
> LS1012A have the same flash chip with 64MB in size? Please clarify.
> 
> York
York,
You are right, all boards has 64MB (S25FS512S) flash.
Sorry for confusion.

SuresH
York Sun May 25, 2017, 3:01 p.m. UTC | #3
On 05/23/2017 10:52 PM, Suresh Gupta wrote:
> 
> 
>> -----Original Message-----
>> From: york sun
>> Sent: Tuesday, May 23, 2017 9:50 PM
>> To: Suresh Gupta <suresh.gupta@nxp.com>; u-boot@lists.denx.de
>> Cc: jagan@openedev.com
>> Subject: Re: [PATCH] LS1012A: change the size of flash
>>
>> On 04/25/2017 02:20 AM, Suresh Gupta wrote:
>>> LS1012A has S25FS512S flash of 64M size
>>>
>>> Signed-off-by: Suresh Gupta <suresh.gupta@nxp.com>
>>> ---
>>>   include/configs/ls1012a_common.h | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/include/configs/ls1012a_common.h
>>> b/include/configs/ls1012a_common.h
>>> index 0db926f..861cbc3 100644
>>> --- a/include/configs/ls1012a_common.h
>>> +++ b/include/configs/ls1012a_common.h
>>> @@ -56,7 +56,7 @@
>>>   #define QSPI0_AMBA_BASE		0x40000000
>>>   #define CONFIG_SPI_FLASH_SPANSION
>>>
>>> -#define FSL_QSPI_FLASH_SIZE		(1 << 24)
>>> +#define FSL_QSPI_FLASH_SIZE		SZ_64M
>>>   #define FSL_QSPI_FLASH_NUM		2
>>>
>>>   /*
>>>
>>
>> Suresh,
>>
>> LS1012A doesn't have any flash built-in. Do you mean all boards supporting
>> LS1012A have the same flash chip with 64MB in size? Please clarify.
>>
>> York
> York,
> You are right, all boards has 64MB (S25FS512S) flash.
> Sorry for confusion.
> 

Changed subject to "armv8: ls1012a: fix the size of flash for multiple 
boards". Revise commit message to "LS1012AFRDM, LS1012ARDB, LS1012AQDS 
all have S25FS512S flash of 64MB size."

Applied to fsl-qoriq master, awaiting upstream. Thanks.

York
diff mbox

Patch

diff --git a/include/configs/ls1012a_common.h b/include/configs/ls1012a_common.h
index 0db926f..861cbc3 100644
--- a/include/configs/ls1012a_common.h
+++ b/include/configs/ls1012a_common.h
@@ -56,7 +56,7 @@ 
 #define QSPI0_AMBA_BASE		0x40000000
 #define CONFIG_SPI_FLASH_SPANSION
 
-#define FSL_QSPI_FLASH_SIZE		(1 << 24)
+#define FSL_QSPI_FLASH_SIZE		SZ_64M
 #define FSL_QSPI_FLASH_NUM		2
 
 /*