diff mbox

[U-Boot] armv8: ls2080ardb: Update default sysclk to 100MHz

Message ID 1492854117-2110-1-git-send-email-priyanka.jain@nxp.com
State Superseded
Headers show

Commit Message

Priyanka Jain April 22, 2017, 9:41 a.m. UTC 
As per board documentation, default sysclk is 100MHz
So, update the default value in ls0280ardb board file
to return 100MHz

Signed-off-by: Priyanka Jain <priyanka.jain@nxp.com>
---
 board/freescale/ls2080ardb/ls2080ardb.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Comments

York Sun April 24, 2017, 3:54 p.m. UTC | #1 
On 04/22/2017 02:42 AM, Priyanka Jain wrote:
> As per board documentation, default sysclk is 100MHz
> So, update the default value in ls0280ardb board file
> to return 100MHz

This doesn't explain why you are changing the clock now. You only need 
this value returned if CPLD is not accessible. You should explain it in 
your commit message.

York
Priyanka Jain April 25, 2017, 4:52 a.m. UTC | #2 
> -----Original Message-----

> From: York Sun [mailto:york.sun@nxp.com]

> Sent: Monday, April 24, 2017 9:24 PM

> To: Priyanka Jain <priyanka.jain@nxp.com>; u-boot@lists.denx.de

> Subject: Re: [PATCH] armv8: ls2080ardb: Update default sysclk to 100MHz

> 

> On 04/22/2017 02:42 AM, Priyanka Jain wrote:

> > As per board documentation, default sysclk is 100MHz So, update the

> > default value in ls0280ardb board file to return 100MHz

> 

> This doesn't explain why you are changing the clock now. You only need this

> value returned if CPLD is not accessible. You should explain it in your commit

> message.

> 

> York

The code change is required only  with "Updae QIXIS code" patch.
So, I have merge this code change with that patch.

Priyanka
diff mbox

Patch

diff --git a/board/freescale/ls2080ardb/ls2080ardb.c b/board/freescale/ls2080ardb/ls2080ardb.c
index 1de5058..1bd555b 100644
--- a/board/freescale/ls2080ardb/ls2080ardb.c
+++ b/board/freescale/ls2080ardb/ls2080ardb.c
@@ -117,7 +117,7 @@  unsigned long get_board_sys_clk(void)
 		return 166666666;
 	}
 #endif
-	return 66666666;
+	return 100000000;
 }
 
 int select_i2c_ch_pca9547(u8 ch)