| Message ID | 1489689480-23775-1-git-send-email-jcmvbkbc@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
On Thu, Mar 16, 2017 at 11:38:00AM -0700, Max Filippov wrote: > When building u-boot tools in cross-build environment CFLAGS environment > variable set up for target is taken into an account when building code > for host. Set it to empty on invocation of python. > > This fixes the following build errors when cross-compiling for xtensa: > > cc1: error: unrecognized command line option "-mlongcalls" > cc1: error: unrecognized command line option "-mauto-litpools" > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> > --- > tools/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/Makefile b/tools/Makefile > index 1c840d7..c224e8a 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -120,7 +120,7 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS) > libfdt: > > tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c > - LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \ > + LDFLAGS="$(HOSTLDFLAGS)" CFLAGS="" python $(srctree)/lib/libfdt/setup.py \ I think we need to be passing in HOSTCFLAGS or we'll end up being broken on certain other cases (which are broken today I suspect). Can you test that out? Thanks!
On Thu, Mar 16, 2017 at 2:11 PM, Tom Rini <trini@konsulko.com> wrote: > On Thu, Mar 16, 2017 at 11:38:00AM -0700, Max Filippov wrote: > >> When building u-boot tools in cross-build environment CFLAGS environment >> variable set up for target is taken into an account when building code >> for host. Set it to empty on invocation of python. >> >> This fixes the following build errors when cross-compiling for xtensa: >> >> cc1: error: unrecognized command line option "-mlongcalls" >> cc1: error: unrecognized command line option "-mauto-litpools" >> >> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> >> --- >> tools/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tools/Makefile b/tools/Makefile >> index 1c840d7..c224e8a 100644 >> --- a/tools/Makefile >> +++ b/tools/Makefile >> @@ -120,7 +120,7 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS) >> libfdt: >> >> tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c >> - LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \ >> + LDFLAGS="$(HOSTLDFLAGS)" CFLAGS="" python $(srctree)/lib/libfdt/setup.py \ > > I think we need to be passing in HOSTCFLAGS or we'll end up being broken > on certain other cases (which are broken today I suspect). I believe that the $(_hostc_flags) in the next line is meant to do exactly that. There's code in the lib/libfdt/setup.py that uses that parameter.
Hi Max, On 16 March 2017 at 12:38, Max Filippov <jcmvbkbc@gmail.com> wrote: > > When building u-boot tools in cross-build environment CFLAGS environment > variable set up for target is taken into an account when building code > for host. Set it to empty on invocation of python. > > This fixes the following build errors when cross-compiling for xtensa: > > cc1: error: unrecognized command line option "-mlongcalls" > cc1: error: unrecognized command line option "-mauto-litpools" > > Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> > --- > tools/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Simon Glass <sjg@chromium.org> Please see below > > diff --git a/tools/Makefile b/tools/Makefile > index 1c840d7..c224e8a 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -120,7 +120,7 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS) > libfdt: > > tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c > - LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \ > + LDFLAGS="$(HOSTLDFLAGS)" CFLAGS="" python $(srctree)/lib/libfdt/setup.py \ Can we drop the "" ? > "$(_hostc_flags)" $^ > mv _libfdt.so $@ > > -- > 2.1.4 > Regards, Simon
diff --git a/tools/Makefile b/tools/Makefile index 1c840d7..c224e8a 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -120,7 +120,7 @@ _libfdt.so-sharedobjs += $(LIBFDT_OBJS) libfdt: tools/_libfdt.so: $(patsubst %.o,%.c,$(LIBFDT_OBJS)) tools/libfdt_wrap.c - LDFLAGS="$(HOSTLDFLAGS)" python $(srctree)/lib/libfdt/setup.py \ + LDFLAGS="$(HOSTLDFLAGS)" CFLAGS="" python $(srctree)/lib/libfdt/setup.py \ "$(_hostc_flags)" $^ mv _libfdt.so $@
When building u-boot tools in cross-build environment CFLAGS environment variable set up for target is taken into an account when building code for host. Set it to empty on invocation of python. This fixes the following build errors when cross-compiling for xtensa: cc1: error: unrecognized command line option "-mlongcalls" cc1: error: unrecognized command line option "-mauto-litpools" Signed-off-by: Max Filippov <jcmvbkbc@gmail.com> --- tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)