| Message ID | 1489483482-18345-1-git-send-email-vinitha.pillai@nxp.com |
|---|---|
| State | Superseded |
| Delegated to: | York Sun |
| Headers | show |
On 03/14/2017 02:25 AM, Vinitha Pillai-B57223 wrote: > After application of SPL size reduction patch, powerPC Please be specific. Which patch/commit broke it? York > compilation breaks, as a macro CONFIG_CMD_BLOB is being > defined for powerpc, but for SPL size reducion blobbing > has been removed for SPL compilation. So that had to be removed > from SPL compilation for powerPC platform as well. > > Signed-off-by: Vinitha Pillai <vinitha.pillai@nxp.com> > Signed-off-by: Sumit Garg <sumit.garg@nxp.com> > --- > arch/powerpc/include/asm/fsl_secure_boot.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/fsl_secure_boot.h b/arch/powerpc/include/asm/fsl_secure_boot.h > index 2e937f0..1f22b77 100644 > --- a/arch/powerpc/include/asm/fsl_secure_boot.h > +++ b/arch/powerpc/include/asm/fsl_secure_boot.h > @@ -107,7 +107,6 @@ > #endif /* ifdef CONFIG_SPL_BUILD */ > > #define CONFIG_CMD_ESBC_VALIDATE > -#define CONFIG_CMD_BLOB > #define CONFIG_FSL_SEC_MON > #define CONFIG_SHA_PROG_HW_ACCEL > #define CONFIG_RSA_FREESCALE_EXP > @@ -117,6 +116,7 @@ > #endif > > #ifndef CONFIG_SPL_BUILD > +#define CONFIG_CMD_BLOB > /* > * fsl_setenv_chain_of_trust() must be called from > * board_late_init() >
Hi York, Sorry, for the delayed response! The commit message wasn't appropriate for the patch, so it has been changed and a new version of that patch has been sent. Since, BLOB feature is not required for T1042 NAND Secure boot, it has been removed from SPL compilation, also considering SPL size restrictions. Best Regards, Vinitha -----Original Message----- From: york sun Sent: Saturday, March 25, 2017 10:42 PM To: Vini Pillai <vinitha.pillai@nxp.com>; u-boot@lists.denx.de Cc: Ruchika Gupta <ruchika.gupta@nxp.com>; Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Sumit Garg <sumit.garg@nxp.com> Subject: Re: [PATCH] T1042RDB: Remove nand secure boot compilation error On 03/14/2017 02:25 AM, Vinitha Pillai-B57223 wrote: > After application of SPL size reduction patch, powerPC Please be specific. Which patch/commit broke it? York > compilation breaks, as a macro CONFIG_CMD_BLOB is being defined for > powerpc, but for SPL size reducion blobbing has been removed for SPL > compilation. So that had to be removed from SPL compilation for > powerPC platform as well. > > Signed-off-by: Vinitha Pillai <vinitha.pillai@nxp.com> > Signed-off-by: Sumit Garg <sumit.garg@nxp.com> > --- > arch/powerpc/include/asm/fsl_secure_boot.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/include/asm/fsl_secure_boot.h > b/arch/powerpc/include/asm/fsl_secure_boot.h > index 2e937f0..1f22b77 100644 > --- a/arch/powerpc/include/asm/fsl_secure_boot.h > +++ b/arch/powerpc/include/asm/fsl_secure_boot.h > @@ -107,7 +107,6 @@ > #endif /* ifdef CONFIG_SPL_BUILD */ > > #define CONFIG_CMD_ESBC_VALIDATE > -#define CONFIG_CMD_BLOB > #define CONFIG_FSL_SEC_MON > #define CONFIG_SHA_PROG_HW_ACCEL > #define CONFIG_RSA_FREESCALE_EXP > @@ -117,6 +116,7 @@ > #endif > > #ifndef CONFIG_SPL_BUILD > +#define CONFIG_CMD_BLOB > /* > * fsl_setenv_chain_of_trust() must be called from > * board_late_init() >
diff --git a/arch/powerpc/include/asm/fsl_secure_boot.h b/arch/powerpc/include/asm/fsl_secure_boot.h index 2e937f0..1f22b77 100644 --- a/arch/powerpc/include/asm/fsl_secure_boot.h +++ b/arch/powerpc/include/asm/fsl_secure_boot.h @@ -107,7 +107,6 @@ #endif /* ifdef CONFIG_SPL_BUILD */ #define CONFIG_CMD_ESBC_VALIDATE -#define CONFIG_CMD_BLOB #define CONFIG_FSL_SEC_MON #define CONFIG_SHA_PROG_HW_ACCEL #define CONFIG_RSA_FREESCALE_EXP @@ -117,6 +116,7 @@ #endif #ifndef CONFIG_SPL_BUILD +#define CONFIG_CMD_BLOB /* * fsl_setenv_chain_of_trust() must be called from * board_late_init()