diff mbox

[U-Boot] LS1021ATWR: Modify u-boot size for sd secureboot

Message ID 1484926338-27973-1-git-send-email-vinitha.pillai@nxp.com
State Accepted
Commit 9b6639fa85bddd90df4c371f25a89c791a6ee6ef
Delegated to: York Sun
Headers show

Commit Message

Vinitha V Pillai Jan. 20, 2017, 3:32 p.m. UTC 
From: Vinitha Pillai <vinitha.pillai@nxp.com>

Raw uboot image is used in place of FIT image in secure boot.
The maximum allocated size of raw u-boot bin is 1MB in memory map.
Hence , CONFIG_SYS_MONITOR_LEN has been modified to 1 MB.
The bootscript  (BS_ADDR) and its header (BS_HDR_ADDR) offset on MMC have also been modified to accommodate the increase in uboot size.

Signed-off-by: Vinitha Pillai-B57223 <vinitha.pillai@nxp.com>
---
 arch/arm/include/asm/fsl_secure_boot.h | 4 ++--
 include/configs/ls1021atwr.h           | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

York Sun Jan. 27, 2017, 5:24 p.m. UTC | #1 
"Secure boot" is a two-word phrase, not one word.

On 01/20/2017 01:35 AM, Vinitha Pillai-B57223 wrote:
> From: Vinitha Pillai <vinitha.pillai@nxp.com>
>
> Raw uboot image is used in place of FIT image in secure boot.
> The maximum allocated size of raw u-boot bin is 1MB in memory map.
> Hence , CONFIG_SYS_MONITOR_LEN has been modified to 1 MB.
> The bootscript  (BS_ADDR) and its header (BS_HDR_ADDR) offset on MMC have also been modified to accommodate the increase in uboot size.

Please wrap back at or before 70 characters. Avoid putting extra white 
space in the message.

>
> Signed-off-by: Vinitha Pillai-B57223 <vinitha.pillai@nxp.com>

Sumit,

This change seems harmless. However I don't have the images setup for 
testing. Please review this patch as the secure boot maintainer.

York
Sumit Garg Jan. 30, 2017, 5:09 a.m. UTC | #2 
> -----Original Message-----
> From: york sun
> Sent: Friday, January 27, 2017 10:55 PM
> To: Vini Pillai <vinitha.pillai@nxp.com>; Sumit Garg <sumit.garg@nxp.com>
> Cc: u-boot@lists.denx.de; Ruchika Gupta <ruchika.gupta@nxp.com>;
> Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: Re: [PATCH] LS1021ATWR: Modify u-boot size for sd secureboot
> 
> "Secure boot" is a two-word phrase, not one word.
> 
> On 01/20/2017 01:35 AM, Vinitha Pillai-B57223 wrote:
> > From: Vinitha Pillai <vinitha.pillai@nxp.com>
> >
> > Raw uboot image is used in place of FIT image in secure boot.
> > The maximum allocated size of raw u-boot bin is 1MB in memory map.
> > Hence , CONFIG_SYS_MONITOR_LEN has been modified to 1 MB.
> > The bootscript  (BS_ADDR) and its header (BS_HDR_ADDR) offset on MMC
> have also been modified to accommodate the increase in uboot size.
> 
> Please wrap back at or before 70 characters. Avoid putting extra white space in
> the message.
> 
> >
> > Signed-off-by: Vinitha Pillai-B57223 <vinitha.pillai@nxp.com>
> 
> Sumit,
> 
> This change seems harmless. However I don't have the images setup for
> testing. Please review this patch as the secure boot maintainer.
> 
> York

Reviewed-by: Sumit Garg <sumit.garg@nxp.com>

Vinitha,

Please incorporate York comments.

Sumit
diff mbox

Patch

diff --git a/arch/arm/include/asm/fsl_secure_boot.h b/arch/arm/include/asm/fsl_secure_boot.h
index 4525287..0ef7315 100644
--- a/arch/arm/include/asm/fsl_secure_boot.h
+++ b/arch/arm/include/asm/fsl_secure_boot.h
@@ -99,8 +99,8 @@ 
 /* For SD boot address and size are assigned in terms of sector
  * offset and no. of sectors respectively.
  */
-#define CONFIG_BS_HDR_ADDR_DEVICE	0x00000800
-#define CONFIG_BS_ADDR_DEVICE		0x00000840
+#define CONFIG_BS_HDR_ADDR_DEVICE	0x00000900
+#define CONFIG_BS_ADDR_DEVICE		0x00000940
 #define CONFIG_BS_HDR_SIZE		0x00000010
 #define CONFIG_BS_SIZE			0x00000008
 #else
diff --git a/include/configs/ls1021atwr.h b/include/configs/ls1021atwr.h
index b48cd00..178239f 100644
--- a/include/configs/ls1021atwr.h
+++ b/include/configs/ls1021atwr.h
@@ -134,9 +134,9 @@ 
  * size increases then increase this size in case of secure boot as
  * it uses raw u-boot image instead of fit image.
  */
-#define CONFIG_SYS_MONITOR_LEN		(0x80000 + CONFIG_U_BOOT_HDR_SIZE)
+#define CONFIG_SYS_MONITOR_LEN		(0x100000 + CONFIG_U_BOOT_HDR_SIZE)
 #else
-#define CONFIG_SYS_MONITOR_LEN		0x80000
+#define CONFIG_SYS_MONITOR_LEN		0x100000
 #endif /* ifdef CONFIG_U_BOOT_HDR_SIZE */
 #endif