diff mbox

[U-Boot] ts4600: Disable CONFIG_DISPLAY_CPUINFO

Message ID 1480533376-12939-1-git-send-email-trini@konsulko.com
State Accepted
Commit 38c4f0bdce5bca8535eadab08ece80dff45ad0ee
Delegated to: Tom Rini
Headers show

Commit Message

Tom Rini Nov. 30, 2016, 7:16 p.m. UTC
Without this change we see:
../arch/arm/cpu/arm926ejs/mxs/mxs.c: In function ‘print_cpuinfo’:
../arch/arm/cpu/arm926ejs/mxs/mxs.c:181:23: warning: unused variable ‘data’ [-Wunused-variable]
../arch/arm/cpu/arm926ejs/mxs/mxs.c:180:6: warning: variable ‘cpurev’ set but not used [-Wunused-but-set-variable]

So the easy solution is to disable CONFIG_DISPLAY_CPUINFO

Cc: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
---
 configs/ts4600_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Sebastien Bourdelin Nov. 30, 2016, 7:34 p.m. UTC | #1
On 11/30/2016 02:16 PM, Tom Rini wrote:
> Without this change we see:
> ../arch/arm/cpu/arm926ejs/mxs/mxs.c: In function ‘print_cpuinfo’:
> ../arch/arm/cpu/arm926ejs/mxs/mxs.c:181:23: warning: unused variable ‘data’ [-Wunused-variable]
> ../arch/arm/cpu/arm926ejs/mxs/mxs.c:180:6: warning: variable ‘cpurev’ set but not used [-Wunused-but-set-variable]
> 
> So the easy solution is to disable CONFIG_DISPLAY_CPUINFO
> 
> Cc: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>
> ---
>  configs/ts4600_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/ts4600_defconfig b/configs/ts4600_defconfig
> index c052dedf1368..1d3acd3c7126 100644
> --- a/configs/ts4600_defconfig
> +++ b/configs/ts4600_defconfig
> @@ -5,6 +5,7 @@ CONFIG_SPL_LIBGENERIC_SUPPORT=y
>  CONFIG_FIT=y
>  CONFIG_SYS_EXTRA_OPTIONS="ENV_IS_IN_MMC"
>  CONFIG_SYS_CONSOLE_IS_IN_ENV=y
> +# CONFIG_DISPLAY_CPUINFO is not set
>  CONFIG_SPL=y
>  CONFIG_HUSH_PARSER=y
>  CONFIG_CMD_BOOTZ=y
> 

Reviewed-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
Tom Rini Dec. 1, 2016, 12:45 a.m. UTC | #2
On Wed, Nov 30, 2016 at 02:16:16PM -0500, Tom Rini wrote:

> Without this change we see:
> ../arch/arm/cpu/arm926ejs/mxs/mxs.c: In function ‘print_cpuinfo’:
> ../arch/arm/cpu/arm926ejs/mxs/mxs.c:181:23: warning: unused variable ‘data’ [-Wunused-variable]
> ../arch/arm/cpu/arm926ejs/mxs/mxs.c:180:6: warning: variable ‘cpurev’ set but not used [-Wunused-but-set-variable]
> 
> So the easy solution is to disable CONFIG_DISPLAY_CPUINFO
> 
> Reviewed-by: Sebastien Bourdelin <sebastien.bourdelin@savoirfairelinux.com>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/configs/ts4600_defconfig b/configs/ts4600_defconfig
index c052dedf1368..1d3acd3c7126 100644
--- a/configs/ts4600_defconfig
+++ b/configs/ts4600_defconfig
@@ -5,6 +5,7 @@  CONFIG_SPL_LIBGENERIC_SUPPORT=y
 CONFIG_FIT=y
 CONFIG_SYS_EXTRA_OPTIONS="ENV_IS_IN_MMC"
 CONFIG_SYS_CONSOLE_IS_IN_ENV=y
+# CONFIG_DISPLAY_CPUINFO is not set
 CONFIG_SPL=y
 CONFIG_HUSH_PARSER=y
 CONFIG_CMD_BOOTZ=y