| Message ID | 1479257416-29389-9-git-send-email-andre.przywara@arm.com |
|---|---|
| State | Accepted |
| Commit | bb72b94e227d292caf158b5b78100c27b2065243 |
| Delegated to: | Tom Rini |
| Headers | show |
On Wed, Nov 16, 2016 at 12:50:12AM +0000, Andre Przywara wrote: > Apparently the indentation is wrong in this case, as the second message > should be printed indepdently of the if statement. > > Fix this indentation to avoid both compiler warnings and puzzled readers. > > Pointed out by GCC 6.2's -Wmisleading-indentation warning. > > Signed-off-by: Andre Przywara <andre.przywara@arm.com> Applied to u-boot/master, thanks!
diff --git a/board/davinci/da8xxevm/da850evm.c b/board/davinci/da8xxevm/da850evm.c index 50223f4..52f914d 100644 --- a/board/davinci/da8xxevm/da850evm.c +++ b/board/davinci/da8xxevm/da850evm.c @@ -164,7 +164,7 @@ int misc_init_r(void) memcmp(env_enetaddr, buff, 6)) printf("Warning: MAC address in SPI flash don't match " "with the MAC address in the environment\n"); - printf("Default using MAC address from environment\n"); + printf("Default using MAC address from environment\n"); } #endif uint8_t enetaddr[8]; @@ -190,7 +190,7 @@ int misc_init_r(void) if (eeprom_mac_read && memcmp(enetaddr, env_enetaddr, 6)) printf("Warning: MAC address in EEPROM don't match " "with the MAC address in the environment\n"); - printf("Default using MAC address from environment\n"); + printf("Default using MAC address from environment\n"); } #endif
Apparently the indentation is wrong in this case, as the second message should be printed indepdently of the if statement. Fix this indentation to avoid both compiler warnings and puzzled readers. Pointed out by GCC 6.2's -Wmisleading-indentation warning. Signed-off-by: Andre Przywara <andre.przywara@arm.com> --- board/davinci/da8xxevm/da850evm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)