diff mbox

[U-Boot,11/13] buildman: Drop the 'active' flag in the builder

Message ID 1474238918-1797-12-git-send-email-sjg@chromium.org
State Accepted
Commit 63781bd65e70719dbab9f2f5bbe8aac7b8e0f13e
Delegated to: Simon Glass
Headers show

Commit Message

Simon Glass Sept. 18, 2016, 10:48 p.m. UTC 
This serves no real purpose, since when we are not active, we exit. Drop it.

Signed-off-by: Simon Glass <sjg@chromium.org>
---

 tools/buildman/builder.py       |  7 -------
 tools/buildman/builderthread.py | 10 +---------
 2 files changed, 1 insertion(+), 16 deletions(-)

Comments

Simon Glass Oct. 2, 2016, 12:29 a.m. UTC | #1 
On 18 September 2016 at 16:48, Simon Glass <sjg@chromium.org> wrote:
> This serves no real purpose, since when we are not active, we exit. Drop it.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
>  tools/buildman/builder.py       |  7 -------
>  tools/buildman/builderthread.py | 10 +---------
>  2 files changed, 1 insertion(+), 16 deletions(-)

Applied to u-boot-dm.
diff mbox

Patch

diff --git a/tools/buildman/builder.py b/tools/buildman/builder.py
index e774c2d..95369f0 100644
--- a/tools/buildman/builder.py
+++ b/tools/buildman/builder.py
@@ -130,7 +130,6 @@  class Builder:
     """Class for building U-Boot for a particular commit.
 
     Public members: (many should ->private)
-        active: True if the builder is active and has not been stopped
         already_done: Number of builds already completed
         base_dir: Base directory to use for builder
         checkout: True to check out source, False to skip that step.
@@ -241,7 +240,6 @@  class Builder:
         self.base_dir = base_dir
         self._working_dir = os.path.join(base_dir, '.bm-work')
         self.threads = []
-        self.active = True
         self.do_make = self.Make
         self.gnu_make = gnu_make
         self.checkout = checkout
@@ -401,11 +399,6 @@  class Builder:
         if result:
             target = result.brd.target
 
-            if result.return_code < 0:
-                self.active = False
-                command.StopAll()
-                return
-
             self.upto += 1
             if result.return_code != 0:
                 self.fail += 1
diff --git a/tools/buildman/builderthread.py b/tools/buildman/builderthread.py
index a30e4fd..06be5d9 100644
--- a/tools/buildman/builderthread.py
+++ b/tools/buildman/builderthread.py
@@ -478,14 +478,6 @@  class BuilderThread(threading.Thread):
         alive = True
         while True:
             job = self.builder.queue.get()
-            if self.builder.active and alive:
+            if alive:
                 self.RunJob(job)
-            '''
-            try:
-                if self.builder.active and alive:
-                    self.RunJob(job)
-            except Exception as err:
-                alive = False
-                print err
-            '''
             self.builder.queue.task_done()