| Message ID | 1473437441-938-2-git-send-email-marcel.ziswiler@toradex.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Warren |
| Headers | show |
On 09/09/2016 10:10 AM, Marcel Ziswiler wrote: > The Tegra 2 aka T20 is not host PC capable. Therefore move the define > CONFIG_CI_UDC_HAS_HOSTPC from the generic tegra-common-usb-gadget.h > header file into resp. SoC type specific ones. This is OK, but ... > diff --git a/include/configs/tegra-common-usb-gadget.h b/include/configs/tegra-common-usb-gadget.h > #ifndef CONFIG_SPL_BUILD > /* USB gadget mode support*/ > -#define CONFIG_CI_UDC_HAS_HOSTPC ... it seems a bit simpler to just wrap that in #ifndef CONFIG_TEGRA20. That would avoid having to duplicate the define in all tegra*-common.h forever. Still, it's not a huge deal.
On Mon, 2016-09-12 at 12:13 -0600, Stephen Warren wrote: > On 09/09/2016 10:10 AM, Marcel Ziswiler wrote: > > > > The Tegra 2 aka T20 is not host PC capable. Therefore move the > > define > > CONFIG_CI_UDC_HAS_HOSTPC from the generic tegra-common-usb-gadget.h > > header file into resp. SoC type specific ones. > This is OK, but ... > > > > > diff --git a/include/configs/tegra-common-usb-gadget.h > > b/include/configs/tegra-common-usb-gadget.h > > > > #ifndef CONFIG_SPL_BUILD > > /* USB gadget mode support*/ > > -#define CONFIG_CI_UDC_HAS_HOSTPC > ... it seems a bit simpler to just wrap that in #ifndef > CONFIG_TEGRA20. > > That would avoid having to duplicate the define in all tegra*- > common.h > forever. Still, it's not a huge deal. Agreed, I will change this in a v2.
diff --git a/include/configs/tegra-common-usb-gadget.h b/include/configs/tegra-common-usb-gadget.h index 3e3eeea..6c6a438 100644 --- a/include/configs/tegra-common-usb-gadget.h +++ b/include/configs/tegra-common-usb-gadget.h @@ -10,7 +10,6 @@ #ifndef CONFIG_SPL_BUILD /* USB gadget mode support*/ -#define CONFIG_CI_UDC_HAS_HOSTPC /* USB mass storage protocol */ #define CONFIG_USB_FUNCTION_MASS_STORAGE /* DFU protocol */ diff --git a/include/configs/tegra114-common.h b/include/configs/tegra114-common.h index 107a0f8..7747e0a 100644 --- a/include/configs/tegra114-common.h +++ b/include/configs/tegra114-common.h @@ -60,6 +60,9 @@ #define CONFIG_SYS_SPL_MALLOC_START 0x80090000 #define CONFIG_SPL_STACK 0x800ffffc +/* For USB gadget mode support */ +#define CONFIG_CI_UDC_HAS_HOSTPC + /* For USB EHCI controller */ #define CONFIG_EHCI_IS_TDI #define CONFIG_USB_EHCI_TXFIFO_THRESH 0x10 diff --git a/include/configs/tegra124-common.h b/include/configs/tegra124-common.h index 8cf9bac..ad3dbbb 100644 --- a/include/configs/tegra124-common.h +++ b/include/configs/tegra124-common.h @@ -62,6 +62,9 @@ #define CONFIG_SYS_SPL_MALLOC_START 0x80090000 #define CONFIG_SPL_STACK 0x800ffffc +/* For USB gadget mode support */ +#define CONFIG_CI_UDC_HAS_HOSTPC + /* For USB EHCI controller */ #define CONFIG_EHCI_IS_TDI #define CONFIG_USB_EHCI_TXFIFO_THRESH 0x10 diff --git a/include/configs/tegra186-common.h b/include/configs/tegra186-common.h index 98e4fc2..68fcf94 100644 --- a/include/configs/tegra186-common.h +++ b/include/configs/tegra186-common.h @@ -65,4 +65,7 @@ #define CONFIG_SYS_SPL_MALLOC_START 0x80090000 #define CONFIG_SPL_STACK 0x800ffffc +/* For USB gadget mode support */ +#define CONFIG_CI_UDC_HAS_HOSTPC + #endif diff --git a/include/configs/tegra210-common.h b/include/configs/tegra210-common.h index 874fe34d..50be2bf 100644 --- a/include/configs/tegra210-common.h +++ b/include/configs/tegra210-common.h @@ -65,6 +65,9 @@ #define CONFIG_SYS_SPL_MALLOC_START 0x80090000 #define CONFIG_SPL_STACK 0x800ffffc +/* For USB gadget mode support */ +#define CONFIG_CI_UDC_HAS_HOSTPC + /* For USB EHCI controller */ #define CONFIG_EHCI_IS_TDI #define CONFIG_USB_EHCI_TXFIFO_THRESH 0x10 diff --git a/include/configs/tegra30-common.h b/include/configs/tegra30-common.h index baf3d00..0a3cd60 100644 --- a/include/configs/tegra30-common.h +++ b/include/configs/tegra30-common.h @@ -67,6 +67,9 @@ #define CONFIG_SYS_SPL_MALLOC_START 0x80090000 #define CONFIG_SPL_STACK 0x800ffffc +/* For USB gadget mode support */ +#define CONFIG_CI_UDC_HAS_HOSTPC + /* For USB EHCI controller */ #define CONFIG_EHCI_IS_TDI #define CONFIG_USB_EHCI_TXFIFO_THRESH 0x10
The Tegra 2 aka T20 is not host PC capable. Therefore move the define CONFIG_CI_UDC_HAS_HOSTPC from the generic tegra-common-usb-gadget.h header file into resp. SoC type specific ones. Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com> --- include/configs/tegra-common-usb-gadget.h | 1 - include/configs/tegra114-common.h | 3 +++ include/configs/tegra124-common.h | 3 +++ include/configs/tegra186-common.h | 3 +++ include/configs/tegra210-common.h | 3 +++ include/configs/tegra30-common.h | 3 +++ 6 files changed, 15 insertions(+), 1 deletion(-)