diff mbox

[U-Boot,1/3] Kconfig: zynqmp: Move config IDENT_STRING to Kconfig

Message ID 1469786509-18626-1-git-send-email-sivadur@xilinx.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Siva Durga Prasad Paladugu July 29, 2016, 10:01 a.m. UTC
Move the config IDENT_STRING to Kconfig for ZynqMP.

Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
---
 common/Kconfig | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jagan Teki July 29, 2016, 10:51 a.m. UTC | #1
On 29 July 2016 at 15:31, Siva Durga Prasad Paladugu
<siva.durga.paladugu@xilinx.com> wrote:
> Move the config IDENT_STRING to Kconfig for ZynqMP.

Didn't understand, from where IDENT_STRING kconfig option is moved
from to common/Kconfig or added new kconfig entry help for
IDENT_STRING.?

>
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> ---
>  common/Kconfig | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/common/Kconfig b/common/Kconfig
> index 46e7173..011f9b3 100644
> --- a/common/Kconfig
> +++ b/common/Kconfig
> @@ -198,6 +198,11 @@ config CONSOLE_RECORD_IN_SIZE
>           The buffer is allocated immediately after the malloc() region is
>           ready.
>
> +config IDENT_STRING
> +       string "Board specific string to be added to uboot version string"
> +       help
> +         This options adds the board specific name to u-boot version.
> +
>  config SYS_NO_FLASH
>         bool "Disable support for parallel NOR flash"
Siva Durga Prasad Paladugu July 29, 2016, 11:18 a.m. UTC | #2
Hi Jagan,

> -----Original Message-----
> From: Jagan Teki [mailto:jagannadh.teki@gmail.com]
> Sent: Friday, July 29, 2016 4:21 PM
> To: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Cc: u-boot@lists.denx.de; Michal Simek <michals@xilinx.com>; Siva Durga
> Prasad Paladugu <sivadur@xilinx.com>
> Subject: Re: [U-Boot] [PATCH 1/3] Kconfig: zynqmp: Move config
> IDENT_STRING to Kconfig
> 
> On 29 July 2016 at 15:31, Siva Durga Prasad Paladugu
> <siva.durga.paladugu@xilinx.com> wrote:
> > Move the config IDENT_STRING to Kconfig for ZynqMP.
> 
> Didn't understand, from where IDENT_STRING kconfig option is moved from to
> common/Kconfig or added new kconfig entry help for IDENT_STRING.?
I meant that it was added to Kconfig. 
I will update description to be more clear in v2.

Thanks,
Siva

> 
> >
> > Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> > ---
> >  common/Kconfig | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/common/Kconfig b/common/Kconfig index 46e7173..011f9b3
> > 100644
> > --- a/common/Kconfig
> > +++ b/common/Kconfig
> > @@ -198,6 +198,11 @@ config CONSOLE_RECORD_IN_SIZE
> >           The buffer is allocated immediately after the malloc() region is
> >           ready.
> >
> > +config IDENT_STRING
> > +       string "Board specific string to be added to uboot version string"
> > +       help
> > +         This options adds the board specific name to u-boot version.
> > +
> >  config SYS_NO_FLASH
> >         bool "Disable support for parallel NOR flash"
> 
> --
> Jagan.
Jagan Teki July 29, 2016, 11:28 a.m. UTC | #3
On 29 July 2016 at 16:48, Siva Durga Prasad Paladugu
<siva.durga.paladugu@xilinx.com> wrote:
> Hi Jagan,
>
>> -----Original Message-----
>> From: Jagan Teki [mailto:jagannadh.teki@gmail.com]
>> Sent: Friday, July 29, 2016 4:21 PM
>> To: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
>> Cc: u-boot@lists.denx.de; Michal Simek <michals@xilinx.com>; Siva Durga
>> Prasad Paladugu <sivadur@xilinx.com>
>> Subject: Re: [U-Boot] [PATCH 1/3] Kconfig: zynqmp: Move config
>> IDENT_STRING to Kconfig
>>
>> On 29 July 2016 at 15:31, Siva Durga Prasad Paladugu
>> <siva.durga.paladugu@xilinx.com> wrote:
>> > Move the config IDENT_STRING to Kconfig for ZynqMP.
>>
>> Didn't understand, from where IDENT_STRING kconfig option is moved from to
>> common/Kconfig or added new kconfig entry help for IDENT_STRING.?
> I meant that it was added to Kconfig.
> I will update description to be more clear in v2.

And also please find the help notes is already there in README
Tom Rini Sept. 21, 2016, 3:30 p.m. UTC | #4
On Fri, Jul 29, 2016 at 03:31:47PM +0530, Siva Durga Prasad Paladugu wrote:

> Move the config IDENT_STRING to Kconfig and migrate all boards
> 
> [sivadur: Migrate zynq boards]
> Signed-off-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> [trini: Update configs, add some default to sunxi Kconfig]
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/Kconfig b/common/Kconfig
index 46e7173..011f9b3 100644
--- a/common/Kconfig
+++ b/common/Kconfig
@@ -198,6 +198,11 @@  config CONSOLE_RECORD_IN_SIZE
 	  The buffer is allocated immediately after the malloc() region is
 	  ready.
 
+config IDENT_STRING
+	string "Board specific string to be added to uboot version string"
+	help
+	  This options adds the board specific name to u-boot version.
+
 config SYS_NO_FLASH
 	bool "Disable support for parallel NOR flash"
 	default n