| Message ID | 1467743839-6724-1-git-send-email-marex@denx.de |
|---|---|
| State | Accepted |
| Commit | 12c67d7522d77c5aa5ee1e5ec4147b569ccb7666 |
| Delegated to: | Marek Vasut |
| Headers | show |
On 07/05/2016 08:37 PM, Marek Vasut wrote: > The errata command is useless in SPL, so don't build it. This fixes > multiple build failures on PowerPC. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: York Sun <york.sun@nxp.com> > Fixes: 92623672f9d3 ("fsl: usb: make errata function common for PPC and ARM") Since 2016.07 is very close and I don't see any other real solution, applied. > --- > arch/powerpc/cpu/mpc85xx/Makefile | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/powerpc/cpu/mpc85xx/Makefile b/arch/powerpc/cpu/mpc85xx/Makefile > index 65c26c0..f4c4fe2 100644 > --- a/arch/powerpc/cpu/mpc85xx/Makefile > +++ b/arch/powerpc/cpu/mpc85xx/Makefile > @@ -26,7 +26,9 @@ else > > obj-$(CONFIG_MP) += release.o > > +ifndef CONFIG_SPL_BUILD > obj-$(CONFIG_CMD_ERRATA) += cmd_errata.o > +endif > obj-$(CONFIG_CPM2) += commproc.o > > obj-$(CONFIG_CPM2) += ether_fcc.o >
On 07/05/2016 11:38 AM, Marek Vasut wrote: > On 07/05/2016 08:37 PM, Marek Vasut wrote: >> The errata command is useless in SPL, so don't build it. This fixes >> multiple build failures on PowerPC. >> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Cc: York Sun <york.sun@nxp.com> >> Fixes: 92623672f9d3 ("fsl: usb: make errata function common for PPC and ARM") > > Since 2016.07 is very close and I don't see any other real solution, > applied. Thank you Marek to take care of this. We will revisit this if Sriram comes up with a better solution. York > >> --- >> arch/powerpc/cpu/mpc85xx/Makefile | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/powerpc/cpu/mpc85xx/Makefile b/arch/powerpc/cpu/mpc85xx/Makefile >> index 65c26c0..f4c4fe2 100644 >> --- a/arch/powerpc/cpu/mpc85xx/Makefile >> +++ b/arch/powerpc/cpu/mpc85xx/Makefile >> @@ -26,7 +26,9 @@ else >> >> obj-$(CONFIG_MP) += release.o >> >> +ifndef CONFIG_SPL_BUILD >> obj-$(CONFIG_CMD_ERRATA) += cmd_errata.o >> +endif >> obj-$(CONFIG_CPM2) += commproc.o >> >> obj-$(CONFIG_CPM2) += ether_fcc.o >> > >
On 07/06/2016 06:33 PM, york sun wrote: > On 07/05/2016 11:38 AM, Marek Vasut wrote: >> On 07/05/2016 08:37 PM, Marek Vasut wrote: >>> The errata command is useless in SPL, so don't build it. This fixes >>> multiple build failures on PowerPC. >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> Cc: York Sun <york.sun@nxp.com> >>> Fixes: 92623672f9d3 ("fsl: usb: make errata function common for PPC and ARM") >> >> Since 2016.07 is very close and I don't see any other real solution, >> applied. > > Thank you Marek to take care of this. We will revisit this if Sriram > comes up with a better solution. Great. I am _really_ unhappy about the patch quality and lack of testing.
On 07/06/2016 10:05 AM, Marek Vasut wrote: > On 07/06/2016 06:33 PM, york sun wrote: >> On 07/05/2016 11:38 AM, Marek Vasut wrote: >>> On 07/05/2016 08:37 PM, Marek Vasut wrote: >>>> The errata command is useless in SPL, so don't build it. This fixes >>>> multiple build failures on PowerPC. >>>> >>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>> Cc: York Sun <york.sun@nxp.com> >>>> Fixes: 92623672f9d3 ("fsl: usb: make errata function common for PPC and ARM") >>> >>> Since 2016.07 is very close and I don't see any other real solution, >>> applied. >> >> Thank you Marek to take care of this. We will revisit this if Sriram >> comes up with a better solution. > > Great. I am _really_ unhappy about the patch quality and lack of testing. > Marek, Even with your patch, we still have a compiling error for kmcoge4 and kmlion1. York
On 07/06/2016 08:49 PM, york sun wrote: > On 07/06/2016 10:05 AM, Marek Vasut wrote: >> On 07/06/2016 06:33 PM, york sun wrote: >>> On 07/05/2016 11:38 AM, Marek Vasut wrote: >>>> On 07/05/2016 08:37 PM, Marek Vasut wrote: >>>>> The errata command is useless in SPL, so don't build it. This fixes >>>>> multiple build failures on PowerPC. >>>>> >>>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>>> Cc: York Sun <york.sun@nxp.com> >>>>> Fixes: 92623672f9d3 ("fsl: usb: make errata function common for PPC and ARM") >>>> >>>> Since 2016.07 is very close and I don't see any other real solution, >>>> applied. >>> >>> Thank you Marek to take care of this. We will revisit this if Sriram >>> comes up with a better solution. >> >> Great. I am _really_ unhappy about the patch quality and lack of testing. >> > > Marek, > > Even with your patch, we still have a compiling error for kmcoge4 and > kmlion1. Can you do a patch ?
On 07/06/2016 03:26 PM, Marek Vasut wrote: > On 07/06/2016 08:49 PM, york sun wrote: >> On 07/06/2016 10:05 AM, Marek Vasut wrote: >>> On 07/06/2016 06:33 PM, york sun wrote: >>>> On 07/05/2016 11:38 AM, Marek Vasut wrote: >>>>> On 07/05/2016 08:37 PM, Marek Vasut wrote: >>>>>> The errata command is useless in SPL, so don't build it. This fixes >>>>>> multiple build failures on PowerPC. >>>>>> >>>>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>>>> Cc: York Sun <york.sun@nxp.com> >>>>>> Fixes: 92623672f9d3 ("fsl: usb: make errata function common for PPC and ARM") >>>>> >>>>> Since 2016.07 is very close and I don't see any other real solution, >>>>> applied. >>>> >>>> Thank you Marek to take care of this. We will revisit this if Sriram >>>> comes up with a better solution. >>> >>> Great. I am _really_ unhappy about the patch quality and lack of testing. >>> >> >> Marek, >> >> Even with your patch, we still have a compiling error for kmcoge4 and >> kmlion1. > > Can you do a patch ? > Sure. Let me work on it. York
On 07/07/2016 12:28 AM, york sun wrote: > On 07/06/2016 03:26 PM, Marek Vasut wrote: >> On 07/06/2016 08:49 PM, york sun wrote: >>> On 07/06/2016 10:05 AM, Marek Vasut wrote: >>>> On 07/06/2016 06:33 PM, york sun wrote: >>>>> On 07/05/2016 11:38 AM, Marek Vasut wrote: >>>>>> On 07/05/2016 08:37 PM, Marek Vasut wrote: >>>>>>> The errata command is useless in SPL, so don't build it. This fixes >>>>>>> multiple build failures on PowerPC. >>>>>>> >>>>>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>>>>> Cc: York Sun <york.sun@nxp.com> >>>>>>> Fixes: 92623672f9d3 ("fsl: usb: make errata function common for PPC and ARM") >>>>>> >>>>>> Since 2016.07 is very close and I don't see any other real solution, >>>>>> applied. >>>>> >>>>> Thank you Marek to take care of this. We will revisit this if Sriram >>>>> comes up with a better solution. >>>> >>>> Great. I am _really_ unhappy about the patch quality and lack of testing. >>>> >>> >>> Marek, >>> >>> Even with your patch, we still have a compiling error for kmcoge4 and >>> kmlion1. >> >> Can you do a patch ? >> > > Sure. Let me work on it. Great, thanks. Deadline is 11th (2016.07 release), so please make it quick.
diff --git a/arch/powerpc/cpu/mpc85xx/Makefile b/arch/powerpc/cpu/mpc85xx/Makefile index 65c26c0..f4c4fe2 100644 --- a/arch/powerpc/cpu/mpc85xx/Makefile +++ b/arch/powerpc/cpu/mpc85xx/Makefile @@ -26,7 +26,9 @@ else obj-$(CONFIG_MP) += release.o +ifndef CONFIG_SPL_BUILD obj-$(CONFIG_CMD_ERRATA) += cmd_errata.o +endif obj-$(CONFIG_CPM2) += commproc.o obj-$(CONFIG_CPM2) += ether_fcc.o
The errata command is useless in SPL, so don't build it. This fixes multiple build failures on PowerPC. Signed-off-by: Marek Vasut <marex@denx.de> Cc: York Sun <york.sun@nxp.com> Fixes: 92623672f9d3 ("fsl: usb: make errata function common for PPC and ARM") --- arch/powerpc/cpu/mpc85xx/Makefile | 2 ++ 1 file changed, 2 insertions(+)