diff mbox

[U-Boot] powerpc: MPC8544DS: revert typo in I2C offset value

Message ID 1467242830-13424-1-git-send-email-york.sun@nxp.com
State Accepted
Commit 7f25fdc7ffab4f7cf80b34ca35600091cdf79b5d
Delegated to: York Sun
Headers show

Commit Message

York Sun June 29, 2016, 11:27 p.m. UTC
From: Benjamin Kamath <bkamath@spaceflight.com>

I2C offset was changed by commit 00f792e0 from 0x3100 to 0x3000.
This typo leads to error when reading SPD from DDR DIMMs.

Signed-off-by: Benjamin Kamath <bkamath@spaceflight.com>
Signed-off-by: York Sun <york.sun@nxp.com>

---

 include/configs/MPC8544DS.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Joe Hershberger June 29, 2016, 11:29 p.m. UTC | #1
Hi York,

On Wed, Jun 29, 2016 at 6:27 PM, York Sun <york.sun@nxp.com> wrote:
> From: Benjamin Kamath <bkamath@spaceflight.com>
>
> I2C offset was changed by commit 00f792e0 from 0x3100 to 0x3000.

Please provide the summary of commit 00f792e0 in parenthesis.

> This typo leads to error when reading SPD from DDR DIMMs.
>
> Signed-off-by: Benjamin Kamath <bkamath@spaceflight.com>
> Signed-off-by: York Sun <york.sun@nxp.com>
>
> ---
>
>  include/configs/MPC8544DS.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/configs/MPC8544DS.h b/include/configs/MPC8544DS.h
> index b9d97c1..321f71e 100644
> --- a/include/configs/MPC8544DS.h
> +++ b/include/configs/MPC8544DS.h
> @@ -209,7 +209,7 @@ extern unsigned long get_board_sys_clk(unsigned long dummy);
>  #define CONFIG_SYS_I2C_FSL
>  #define CONFIG_SYS_FSL_I2C_SPEED       400000
>  #define CONFIG_SYS_FSL_I2C_SLAVE       0x7F
> -#define CONFIG_SYS_FSL_I2C_OFFSET      0x3000
> +#define CONFIG_SYS_FSL_I2C_OFFSET      0x3100
>  #define CONFIG_SYS_I2C_NOPROBES                { {0, 0x69} }
>  #define CONFIG_SYS_I2C_EEPROM_ADDR     0x57
>
> --
> 2.7.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
diff mbox

Patch

diff --git a/include/configs/MPC8544DS.h b/include/configs/MPC8544DS.h
index b9d97c1..321f71e 100644
--- a/include/configs/MPC8544DS.h
+++ b/include/configs/MPC8544DS.h
@@ -209,7 +209,7 @@  extern unsigned long get_board_sys_clk(unsigned long dummy);
 #define CONFIG_SYS_I2C_FSL
 #define CONFIG_SYS_FSL_I2C_SPEED	400000
 #define CONFIG_SYS_FSL_I2C_SLAVE	0x7F
-#define CONFIG_SYS_FSL_I2C_OFFSET	0x3000
+#define CONFIG_SYS_FSL_I2C_OFFSET	0x3100
 #define CONFIG_SYS_I2C_NOPROBES		{ {0, 0x69} }
 #define CONFIG_SYS_I2C_EEPROM_ADDR	0x57