| Message ID | 1464356373-8375-3-git-send-email-ravibabu@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Ravi, > Adding ext4/fat filesytem support for SPL-DFU to > write ext4/fat files to eMMC, MMC/SD device > > Signed-off-by: Ravi Babu <ravibabu@ti.com> > --- > cmd/Makefile | 9 +++++++++ > common/Makefile | 4 +++- > fs/Makefile | 12 +++++++++++- > 3 files changed, 23 insertions(+), 2 deletions(-) > > diff --git a/cmd/Makefile b/cmd/Makefile > index 139189e..ad89e09 100644 > --- a/cmd/Makefile > +++ b/cmd/Makefile > @@ -12,6 +12,15 @@ CONFIG_INC_COMMON=n > endif > endif > > +ifeq ($(CONFIG_INC_COMMON),y) > +obj-$(CONFIG_CMD_EXT4) += ext4.o > +obj-$(CONFIG_CMD_EXT2) += ext2.o > +obj-$(CONFIG_CMD_FAT) += fat.o > +obj-$(CONFIG_CMD_FDC) += fdc.o > +obj-$(CONFIG_CMD_FS_GENERIC) += fs.o > +obj-$(CONFIG_CMD_SCSI) += scsi.o > +endif Could we extend code from ./common/spl/spl_fat.c or ./common/spl/spl_ext to support write ? > + > ifndef CONFIG_SPL_BUILD > # core command > obj-y += boot.o > diff --git a/common/Makefile b/common/Makefile > index 3576fac..99de9e1 100644 > --- a/common/Makefile > +++ b/common/Makefile > @@ -24,6 +24,9 @@ obj-y += env_attr.o > obj-y += env_callback.o > obj-y += env_flags.o > obj-y += cli.o > +ifdef CONFIG_CMD_USB > +obj-$(CONFIG_USB_STORAGE) += usb_storage.o > +endif > endif > > ifndef CONFIG_SPL_BUILD > @@ -78,7 +81,6 @@ obj-$(CONFIG_PHYLIB) += miiphyutil.o > > ifdef CONFIG_CMD_USB > obj-y += usb.o usb_hub.o > -obj-$(CONFIG_USB_STORAGE) += usb_storage.o > endif > > # others > diff --git a/fs/Makefile b/fs/Makefile > index 51d06fc..d4490a9 100644 > --- a/fs/Makefile > +++ b/fs/Makefile > @@ -6,11 +6,21 @@ > # SPDX-License-Identifier: GPL-2.0+ > # > > +CONFIG_INC_COMMON=y > +ifdef CONFIG_SPL_BUILD > +ifndef CONFIG_SPL_DFU > +CONFIG_INC_COMMON=n > +endif > +endif > + > +ifeq ($(CONFIG_INC_COMMON),y) > +obj-y += fs.o > +endif > + > ifdef CONFIG_SPL_BUILD > obj-$(CONFIG_SPL_FAT_SUPPORT) += fat/ > obj-$(CONFIG_SPL_EXT_SUPPORT) += ext4/ > else > -obj-y += fs.o > > obj-$(CONFIG_CMD_CBFS) += cbfs/ > obj-$(CONFIG_CMD_CRAMFS) += cramfs/ Just side question: How large could be the SPL code for your board (dra7x)?
Hi Lukasz > On 30-May-2016, at 5:30 PM, Lukasz Majewski <l.majewski@samsung.com> wrote: > > Hi Ravi, > >> Adding ext4/fat filesytem support for SPL-DFU to >> write ext4/fat files to eMMC, MMC/SD device >> >> Signed-off-by: Ravi Babu <ravibabu@ti.com> >> --- >> cmd/Makefile | 9 +++++++++ >> common/Makefile | 4 +++- >> fs/Makefile | 12 +++++++++++- >> 3 files changed, 23 insertions(+), 2 deletions(-) >> >> diff --git a/cmd/Makefile b/cmd/Makefile >> index 139189e..ad89e09 100644 >> --- a/cmd/Makefile >> +++ b/cmd/Makefile >> @@ -12,6 +12,15 @@ CONFIG_INC_COMMON=n >> endif >> endif >> >> +ifeq ($(CONFIG_INC_COMMON),y) >> +obj-$(CONFIG_CMD_EXT4) += ext4.o >> +obj-$(CONFIG_CMD_EXT2) += ext2.o >> +obj-$(CONFIG_CMD_FAT) += fat.o >> +obj-$(CONFIG_CMD_FDC) += fdc.o >> +obj-$(CONFIG_CMD_FS_GENERIC) += fs.o >> +obj-$(CONFIG_CMD_SCSI) += scsi.o >> +endif > > Could we extend code from ./common/spl/spl_fat.c > or ./common/spl/spl_ext to support write ? > I will check this and let you know. >> + >> ifndef CONFIG_SPL_BUILD >> # core command >> obj-y += boot.o >> diff --git a/common/Makefile b/common/Makefile >> index 3576fac..99de9e1 100644 >> --- a/common/Makefile >> +++ b/common/Makefile >> @@ -24,6 +24,9 @@ obj-y += env_attr.o >> obj-y += env_callback.o >> obj-y += env_flags.o >> obj-y += cli.o >> +ifdef CONFIG_CMD_USB >> +obj-$(CONFIG_USB_STORAGE) += usb_storage.o >> +endif >> endif >> >> ifndef CONFIG_SPL_BUILD >> @@ -78,7 +81,6 @@ obj-$(CONFIG_PHYLIB) += miiphyutil.o >> >> ifdef CONFIG_CMD_USB >> obj-y += usb.o usb_hub.o >> -obj-$(CONFIG_USB_STORAGE) += usb_storage.o >> endif >> >> # others >> diff --git a/fs/Makefile b/fs/Makefile >> index 51d06fc..d4490a9 100644 >> --- a/fs/Makefile >> +++ b/fs/Makefile >> @@ -6,11 +6,21 @@ >> # SPDX-License-Identifier: GPL-2.0+ >> # >> >> +CONFIG_INC_COMMON=y >> +ifdef CONFIG_SPL_BUILD >> +ifndef CONFIG_SPL_DFU >> +CONFIG_INC_COMMON=n >> +endif >> +endif >> + >> +ifeq ($(CONFIG_INC_COMMON),y) >> +obj-y += fs.o >> +endif >> + >> ifdef CONFIG_SPL_BUILD >> obj-$(CONFIG_SPL_FAT_SUPPORT) += fat/ >> obj-$(CONFIG_SPL_EXT_SUPPORT) += ext4/ >> else >> -obj-y += fs.o >> >> obj-$(CONFIG_CMD_CBFS) += cbfs/ >> obj-$(CONFIG_CMD_CRAMFS) += cramfs/ > > Just side question: > > How large could be the SPL code for your board (dra7x)? > The SPL code size is about 152K. > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Hi Ravi, > > > > How large could be the SPL code for your board (dra7x)? > > > > The SPL code size is about 152K. And what is the overall size of IRAM on this board? My concern here is that other potential users of DFU SPL boards could have smaller available memory (for example 64KiB or even better - 24KiB). That is why we struggle to have the SPL as tiny as possible.
Lucasz > On 30-May-2016, at 6:51 PM, Lukasz Majewski <l.majewski@samsung.com> wrote: > > Hi Ravi, > >>> >>> How large could be the SPL code for your board (dra7x)? >> >> The SPL code size is about 152K. > > And what is the overall size of IRAM on this board? > > My concern here is that other potential users of DFU SPL boards could > have smaller available memory (for example 64KiB or even better - > 24KiB). > > That is why we struggle to have the SPL as tiny as possible. > Yes, I am aware of this, the dra7x has 512kb. SPL-DFU shall enabled only for platform has IRAM has more space. > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
diff --git a/cmd/Makefile b/cmd/Makefile index 139189e..ad89e09 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -12,6 +12,15 @@ CONFIG_INC_COMMON=n endif endif +ifeq ($(CONFIG_INC_COMMON),y) +obj-$(CONFIG_CMD_EXT4) += ext4.o +obj-$(CONFIG_CMD_EXT2) += ext2.o +obj-$(CONFIG_CMD_FAT) += fat.o +obj-$(CONFIG_CMD_FDC) += fdc.o +obj-$(CONFIG_CMD_FS_GENERIC) += fs.o +obj-$(CONFIG_CMD_SCSI) += scsi.o +endif + ifndef CONFIG_SPL_BUILD # core command obj-y += boot.o diff --git a/common/Makefile b/common/Makefile index 3576fac..99de9e1 100644 --- a/common/Makefile +++ b/common/Makefile @@ -24,6 +24,9 @@ obj-y += env_attr.o obj-y += env_callback.o obj-y += env_flags.o obj-y += cli.o +ifdef CONFIG_CMD_USB +obj-$(CONFIG_USB_STORAGE) += usb_storage.o +endif endif ifndef CONFIG_SPL_BUILD @@ -78,7 +81,6 @@ obj-$(CONFIG_PHYLIB) += miiphyutil.o ifdef CONFIG_CMD_USB obj-y += usb.o usb_hub.o -obj-$(CONFIG_USB_STORAGE) += usb_storage.o endif # others diff --git a/fs/Makefile b/fs/Makefile index 51d06fc..d4490a9 100644 --- a/fs/Makefile +++ b/fs/Makefile @@ -6,11 +6,21 @@ # SPDX-License-Identifier: GPL-2.0+ # +CONFIG_INC_COMMON=y +ifdef CONFIG_SPL_BUILD +ifndef CONFIG_SPL_DFU +CONFIG_INC_COMMON=n +endif +endif + +ifeq ($(CONFIG_INC_COMMON),y) +obj-y += fs.o +endif + ifdef CONFIG_SPL_BUILD obj-$(CONFIG_SPL_FAT_SUPPORT) += fat/ obj-$(CONFIG_SPL_EXT_SUPPORT) += ext4/ else -obj-y += fs.o obj-$(CONFIG_CMD_CBFS) += cbfs/ obj-$(CONFIG_CMD_CRAMFS) += cramfs/
Adding ext4/fat filesytem support for SPL-DFU to write ext4/fat files to eMMC, MMC/SD device Signed-off-by: Ravi Babu <ravibabu@ti.com> --- cmd/Makefile | 9 +++++++++ common/Makefile | 4 +++- fs/Makefile | 12 +++++++++++- 3 files changed, 23 insertions(+), 2 deletions(-)