| Message ID | 1463990096-2977-1-git-send-email-mario.six@gdsys.cc |
|---|---|
| State | Accepted |
| Commit | fc76b698736efa9d52e06aa09c03dc8ef10fd581 |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Mario, On Mon, May 23, 2016 at 09:54:56AM +0200, Mario Six wrote: >A bug in the pca953x driver prevents correct reading of GPIO input >values beyond the 8th GPIO; all values are reported as zero. Setting of >GPIO output values is not affected. > >This patch fixes the reading behavior. > >Signed-off-by: Mario Six <mario.six@gdsys.cc> Reviewed-by: Peng Fan <van.freenix@gmail.com> Regards, Peng. >--- > drivers/gpio/pca953x_gpio.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/drivers/gpio/pca953x_gpio.c b/drivers/gpio/pca953x_gpio.c >index 987d10e..3cbfa09 100644 >--- a/drivers/gpio/pca953x_gpio.c >+++ b/drivers/gpio/pca953x_gpio.c >@@ -145,11 +145,13 @@ static int pca953x_get_value(struct udevice *dev, unsigned offset) > int ret; > u8 val = 0; > >+ int off = offset % BANK_SZ; >+ > ret = pca953x_read_single(dev, PCA953X_INPUT, &val, offset); > if (ret) > return ret; > >- return (val >> offset) & 0x1; >+ return (val >> off) & 0x1; > } > > static int pca953x_set_value(struct udevice *dev, unsigned offset, >-- >2.7.0.GIT >
On 23 May 2016 at 02:15, Peng Fan <van.freenix@gmail.com> wrote: > Hi Mario, > > On Mon, May 23, 2016 at 09:54:56AM +0200, Mario Six wrote: >>A bug in the pca953x driver prevents correct reading of GPIO input >>values beyond the 8th GPIO; all values are reported as zero. Setting of >>GPIO output values is not affected. >> >>This patch fixes the reading behavior. >> >>Signed-off-by: Mario Six <mario.six@gdsys.cc> > > Reviewed-by: Peng Fan <van.freenix@gmail.com> Acked-by: Simon Glass <sjg@chromium.org>
On 7 June 2016 at 20:43, Simon Glass <sjg@chromium.org> wrote: > On 23 May 2016 at 02:15, Peng Fan <van.freenix@gmail.com> wrote: >> Hi Mario, >> >> On Mon, May 23, 2016 at 09:54:56AM +0200, Mario Six wrote: >>>A bug in the pca953x driver prevents correct reading of GPIO input >>>values beyond the 8th GPIO; all values are reported as zero. Setting of >>>GPIO output values is not affected. >>> >>>This patch fixes the reading behavior. >>> >>>Signed-off-by: Mario Six <mario.six@gdsys.cc> >> >> Reviewed-by: Peng Fan <van.freenix@gmail.com> > > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot-dm, thanks!
diff --git a/drivers/gpio/pca953x_gpio.c b/drivers/gpio/pca953x_gpio.c index 987d10e..3cbfa09 100644 --- a/drivers/gpio/pca953x_gpio.c +++ b/drivers/gpio/pca953x_gpio.c @@ -145,11 +145,13 @@ static int pca953x_get_value(struct udevice *dev, unsigned offset) int ret; u8 val = 0; + int off = offset % BANK_SZ; + ret = pca953x_read_single(dev, PCA953X_INPUT, &val, offset); if (ret) return ret; - return (val >> offset) & 0x1; + return (val >> off) & 0x1; } static int pca953x_set_value(struct udevice *dev, unsigned offset,
A bug in the pca953x driver prevents correct reading of GPIO input values beyond the 8th GPIO; all values are reported as zero. Setting of GPIO output values is not affected. This patch fixes the reading behavior. Signed-off-by: Mario Six <mario.six@gdsys.cc> --- drivers/gpio/pca953x_gpio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)