diff mbox

[U-Boot,3/4] usb: dwc3: Makefile: Don't build gadget code if USB_GADGET is disabled

Message ID 1463141873-10604-4-git-send-email-rogerq@ti.com
State Accepted
Commit 3ac8d1ee12dcc59942c22f76ccce5537fc3a198a
Delegated to: Tom Rini
Headers show

Commit Message

Roger Quadros May 13, 2016, 12:17 p.m. UTC 
It is pointless to build gadget driver if USB_GADGET is disabled.

Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 drivers/usb/dwc3/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marek Vasut May 13, 2016, 12:24 p.m. UTC | #1 
On 05/13/2016 02:17 PM, Roger Quadros wrote:
> It is pointless to build gadget driver if USB_GADGET is disabled.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Acked-by: Marek Vasut <marex@denx.de>

> ---
>  drivers/usb/dwc3/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile
> index 0cd7302..2964bae 100644
> --- a/drivers/usb/dwc3/Makefile
> +++ b/drivers/usb/dwc3/Makefile
> @@ -6,7 +6,7 @@ obj-$(CONFIG_USB_DWC3)			+= dwc3.o
>  
>  dwc3-y					:= core.o
>  
> -dwc3-y					+= gadget.o ep0.o
> +obj-$(CONFIG_USB_DWC3_GADGET)		+= gadget.o ep0.o
>  
>  obj-$(CONFIG_USB_DWC3_OMAP)		+= dwc3-omap.o
>  obj-$(CONFIG_USB_DWC3_PHY_OMAP)		+= ti_usb_phy.o
>
Tom Rini May 30, 2016, 5:58 p.m. UTC | #2 
On Fri, May 13, 2016 at 03:17:52PM +0300, Roger Quadros wrote:

> It is pointless to build gadget driver if USB_GADGET is disabled.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> Acked-by: Marek Vasut <marex@denx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/drivers/usb/dwc3/Makefile b/drivers/usb/dwc3/Makefile
index 0cd7302..2964bae 100644
--- a/drivers/usb/dwc3/Makefile
+++ b/drivers/usb/dwc3/Makefile
@@ -6,7 +6,7 @@  obj-$(CONFIG_USB_DWC3)			+= dwc3.o
 
 dwc3-y					:= core.o
 
-dwc3-y					+= gadget.o ep0.o
+obj-$(CONFIG_USB_DWC3_GADGET)		+= gadget.o ep0.o
 
 obj-$(CONFIG_USB_DWC3_OMAP)		+= dwc3-omap.o
 obj-$(CONFIG_USB_DWC3_PHY_OMAP)		+= ti_usb_phy.o