| Message ID | 1460966536-16910-1-git-send-email-ysato@users.sourceforge.jp |
|---|---|
| State | Accepted |
| Commit | 6d9f5b035d73129fe0ba4c0d28af55ee565e2490 |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Yoshinori, On 18 April 2016 at 02:02, Yoshinori Sato <ysato@users.sourceforge.jp> wrote: > Don't lookup pci device 1f.7 > > Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> > --- > drivers/pci/pci-uclass.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c > index c7fbf7b..32590ce 100644 > --- a/drivers/pci/pci-uclass.c > +++ b/drivers/pci/pci-uclass.c > @@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus) > found_multi = false; > end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1, > PCI_MAX_PCI_FUNCTIONS - 1); > - for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end; > + for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end; > bdf += PCI_BDF(0, 0, 1)) { > struct pci_child_platdata *pplat; > struct udevice *dev; The patch looks good thank you. But your commit message seem the opposite of what this patch does. Can you update it in v2, or explain it better? Regards, Simon
diff --git a/drivers/pci/pci-uclass.c b/drivers/pci/pci-uclass.c index c7fbf7b..32590ce 100644 --- a/drivers/pci/pci-uclass.c +++ b/drivers/pci/pci-uclass.c @@ -682,7 +682,7 @@ int pci_bind_bus_devices(struct udevice *bus) found_multi = false; end = PCI_BDF(bus->seq, PCI_MAX_PCI_DEVICES - 1, PCI_MAX_PCI_FUNCTIONS - 1); - for (bdf = PCI_BDF(bus->seq, 0, 0); bdf < end; + for (bdf = PCI_BDF(bus->seq, 0, 0); bdf <= end; bdf += PCI_BDF(0, 0, 1)) { struct pci_child_platdata *pplat; struct udevice *dev;
Don't lookup pci device 1f.7 Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp> --- drivers/pci/pci-uclass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)