diff mbox

[U-Boot,2/8] usb: gadget: Add CONFIG_USB_GADGET_DUALSPEED to Kconfig

Message ID 1459874197-14460-3-git-send-email-semen.protsenko@linaro.org
State Superseded
Delegated to: Przemyslaw Marczak
Headers show

Commit Message

Sam Protsenko April 5, 2016, 4:36 p.m. UTC 
From: Sam Protsenko <semen.protsenko@linaro.org>

It's hard to migrate all configs to this option in one patch, as this
option should be selected by UDC controller options, and some of them
are not added to Kconfig yet. So let's first add this option to Kconfig
and then select it for all controllers one by one.

Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
---
 drivers/usb/gadget/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Stephen Warren April 5, 2016, 5:39 p.m. UTC | #1 
On 04/05/2016 10:36 AM, Semen Protsenko wrote:
> From: Sam Protsenko <semen.protsenko@linaro.org>
>
> It's hard to migrate all configs to this option in one patch, as this
> option should be selected by UDC controller options, and some of them
> are not added to Kconfig yet. So let's first add this option to Kconfig
> and then select it for all controllers one by one.

Isn't that going to cause build failures if someone compiles a part part 
way through this series? I imagine that moving the variable into 
Kconfig, but still #defining it in a header file, will cause conflicts. 
That will be annoying to people using "git bisect".
diff mbox

Patch

diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
index 17ca316..fd7ec22 100644
--- a/drivers/usb/gadget/Kconfig
+++ b/drivers/usb/gadget/Kconfig
@@ -53,4 +53,8 @@  config USB_GADGET_VBUS_DRAW
 	   This value will be used except for system-specific gadget
 	   drivers that have more specific information.
 
+# Selected by UDC drivers that support high-speed operation.
+config USB_GADGET_DUALSPEED
+	bool
+
 endif # USB_GADGET