diff mbox

[U-Boot] board: ti: am57xx: Prevent init_sata() from being called twice

Message ID 1459756411-3991-1-git-send-email-rogerq@ti.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Roger Quadros April 4, 2016, 7:53 a.m. UTC
init_sata() is done as part of scsi_init() in
arch/arm/cpu/armv7/omap-common/sata.c so no need to duplicate
it here.

This seems to fix SATA problems in the kernel when CONFIG_TI_PIPE3 is
configured as loadable module.

Cc: Cooper Jr., Franklin <fcooper@ti.com>
Cc: Nishanth Menon <nm@ti.com>
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
 board/ti/am57xx/board.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Tom Rini April 12, 2016, 2:29 a.m. UTC | #1
On Mon, Apr 04, 2016 at 10:53:31AM +0300, Roger Quadros wrote:

> init_sata() is done as part of scsi_init() in
> arch/arm/cpu/armv7/omap-common/sata.c so no need to duplicate
> it here.
> 
> This seems to fix SATA problems in the kernel when CONFIG_TI_PIPE3 is
> configured as loadable module.
> 
> Cc: Cooper Jr., Franklin <fcooper@ti.com>
> Cc: Nishanth Menon <nm@ti.com>
> Signed-off-by: Roger Quadros <rogerq@ti.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/board/ti/am57xx/board.c b/board/ti/am57xx/board.c
index 042f9ab..34c5161 100644
--- a/board/ti/am57xx/board.c
+++ b/board/ti/am57xx/board.c
@@ -264,7 +264,6 @@  int board_init(void)
 
 int board_late_init(void)
 {
-	init_sata(0);
 	/*
 	 * DEV_CTRL.DEV_ON = 1 please - else palmas switches off in 8 seconds
 	 * This is the POWERHOLD-in-Low behavior.