diff mbox

[U-Boot,2/2] mx7dsabresd: Define serial port locally

Message ID 1456177308-18574-2-git-send-email-festevam@gmail.com
State Accepted
Commit 5d69269deed053d2733bdd0fe537fcba663c0826
Delegated to: Stefano Babic
Headers show

Commit Message

Fabio Estevam Feb. 22, 2016, 9:41 p.m. UTC 
From: Fabio Estevam <fabio.estevam@nxp.com>

CONFIG_MXC_UART_BASE should not be defined in mx7_common.h as
the console port can vary from board to board.

Define CONFIG_MXC_UART_BASE locally instead.

Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
 include/configs/mx7_common.h  | 1 -
 include/configs/mx7dsabresd.h | 2 ++
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Stefano Babic March 9, 2016, 11:48 a.m. UTC | #1 
On 22/02/2016 22:41, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
> 
> CONFIG_MXC_UART_BASE should not be defined in mx7_common.h as
> the console port can vary from board to board.
> 
> Define CONFIG_MXC_UART_BASE locally instead.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
>  include/configs/mx7_common.h  | 1 -
>  include/configs/mx7dsabresd.h | 2 ++
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/include/configs/mx7_common.h b/include/configs/mx7_common.h
> index b2a8756..bfad696 100644
> --- a/include/configs/mx7_common.h
> +++ b/include/configs/mx7_common.h
> @@ -77,7 +77,6 @@
>  
>  /* UART */
>  #define CONFIG_MXC_UART
> -#define CONFIG_MXC_UART_BASE            UART1_IPS_BASE_ADDR
>  
>  /* MMC */
>  #define CONFIG_MMC
> diff --git a/include/configs/mx7dsabresd.h b/include/configs/mx7dsabresd.h
> index 2c981e0..b8b5b45 100644
> --- a/include/configs/mx7dsabresd.h
> +++ b/include/configs/mx7dsabresd.h
> @@ -14,6 +14,8 @@
>  #define CONFIG_DBG_MONITOR
>  #define PHYS_SDRAM_SIZE			SZ_1G
>  
> +#define CONFIG_MXC_UART_BASE            UART1_IPS_BASE_ADDR
> +
>  /* Uncomment to enable secure boot support */
>  /* #define CONFIG_SECURE_BOOT */
>  #define CONFIG_CSF_SIZE			0x4000
> 
Applied to -next, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/mx7_common.h b/include/configs/mx7_common.h
index b2a8756..bfad696 100644
--- a/include/configs/mx7_common.h
+++ b/include/configs/mx7_common.h
@@ -77,7 +77,6 @@ 
 
 /* UART */
 #define CONFIG_MXC_UART
-#define CONFIG_MXC_UART_BASE            UART1_IPS_BASE_ADDR
 
 /* MMC */
 #define CONFIG_MMC
diff --git a/include/configs/mx7dsabresd.h b/include/configs/mx7dsabresd.h
index 2c981e0..b8b5b45 100644
--- a/include/configs/mx7dsabresd.h
+++ b/include/configs/mx7dsabresd.h
@@ -14,6 +14,8 @@ 
 #define CONFIG_DBG_MONITOR
 #define PHYS_SDRAM_SIZE			SZ_1G
 
+#define CONFIG_MXC_UART_BASE            UART1_IPS_BASE_ADDR
+
 /* Uncomment to enable secure boot support */
 /* #define CONFIG_SECURE_BOOT */
 #define CONFIG_CSF_SIZE			0x4000