diff mbox

[U-Boot,1/3] mips: ath79: Fix compiler warning on const assignment

Message ID 1453938669-7273-1-git-send-email-marex@denx.de
State Accepted
Commit 43a092ffdd5edd6a66e8e9ec34372f3abd396486
Delegated to: Daniel Schwierzeck
Headers show

Commit Message

Marek Vasut Jan. 27, 2016, 11:51 p.m. UTC
The assignment const T var; var = value; is illegal, since var is
constant. Drop the const to fix the compiler warning.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
Cc: Wills Wang <wills.wang@live.com>
---
 arch/mips/mach-ath79/reset.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Wills Wang Jan. 28, 2016, 1:23 p.m. UTC | #1
On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
> The assignment const T var; var = value; is illegal, since var is
> constant. Drop the const to fix the compiler warning.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> Cc: Wills Wang <wills.wang@live.com>
> ---
>   arch/mips/mach-ath79/reset.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c
> index 504b833..e8f5796 100644
> --- a/arch/mips/mach-ath79/reset.c
> +++ b/arch/mips/mach-ath79/reset.c
> @@ -46,7 +46,7 @@ void _machine_restart(void)
>   
>   u32 get_bootstrap(void)
>   {
> -	const void __iomem *base;
> +	void __iomem *base;
>   	u32 reg = 0;
>   
>   	base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,
I have dropped "const" in the coming v8.
Marek Vasut Jan. 28, 2016, 1:25 p.m. UTC | #2
On Thursday, January 28, 2016 at 02:23:48 PM, Wills Wang wrote:
> On Thursday, January 28, 2016 07:51 AM, Marek Vasut wrote:
> > The assignment const T var; var = value; is illegal, since var is
> > constant. Drop the const to fix the compiler warning.
> > 
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com>
> > Cc: Wills Wang <wills.wang@live.com>
> > ---
> > 
> >   arch/mips/mach-ath79/reset.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c
> > index 504b833..e8f5796 100644
> > --- a/arch/mips/mach-ath79/reset.c
> > +++ b/arch/mips/mach-ath79/reset.c
> > @@ -46,7 +46,7 @@ void _machine_restart(void)
> > 
> >   u32 get_bootstrap(void)
> >   {
> > 
> > -	const void __iomem *base;
> > +	void __iomem *base;
> > 
> >   	u32 reg = 0;
> >   	
> >   	base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,
> 
> I have dropped "const" in the coming v8.

Fine

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/arch/mips/mach-ath79/reset.c b/arch/mips/mach-ath79/reset.c
index 504b833..e8f5796 100644
--- a/arch/mips/mach-ath79/reset.c
+++ b/arch/mips/mach-ath79/reset.c
@@ -46,7 +46,7 @@  void _machine_restart(void)
 
 u32 get_bootstrap(void)
 {
-	const void __iomem *base;
+	void __iomem *base;
 	u32 reg = 0;
 
 	base = map_physmem(AR71XX_RESET_BASE, AR71XX_RESET_SIZE,