| Message ID | 1452104488-5502-6-git-send-email-mateusz.kulikowski@gmail.com |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
On Wednesday, January 06, 2016 at 07:21:17 PM, Mateusz Kulikowski wrote: > The following options can be now enabled via defconfig: > - CONFIG_USB_ULPI > - CONFIG_USB_ULPI_VIEWPORT > - CONFIG_USB_ULPI_VIEWPORT_OMAP > > Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> > --- > > Changes in v1: New patch > > drivers/usb/Kconfig | 2 ++ > drivers/usb/ulpi/Kconfig | 10 ++++++++++ > 2 files changed, 12 insertions(+) > create mode 100644 drivers/usb/ulpi/Kconfig > > diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig > index abb06fc..57b99f2 100644 > --- a/drivers/usb/Kconfig > +++ b/drivers/usb/Kconfig > @@ -53,6 +53,8 @@ source "drivers/usb/musb-new/Kconfig" > > source "drivers/usb/emul/Kconfig" > > +source "drivers/usb/ulpi/Kconfig" > + > comment "USB peripherals" > > config USB_STORAGE > diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig > new file mode 100644 > index 0000000..f3210bc > --- /dev/null > +++ b/drivers/usb/ulpi/Kconfig > @@ -0,0 +1,10 @@ > +comment "ULPI drivers" > + > +config USB_ULPI > + bool > + > +config USB_ULPI_VIEWPORT > + bool > + > +config USB_ULPI_VIEWPORT_OMAP > + bool Description of these options is missing. Best regards, Marek Vasut
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06.01.2016 21:49, Marek Vasut wrote: > On Wednesday, January 06, 2016 at 07:21:17 PM, Mateusz Kulikowski wrote: >> The following options can be now enabled via defconfig: >> - CONFIG_USB_ULPI >> - CONFIG_USB_ULPI_VIEWPORT >> - CONFIG_USB_ULPI_VIEWPORT_OMAP >> [...] >> +++ b/drivers/usb/ulpi/Kconfig >> @@ -0,0 +1,10 @@ >> +comment "ULPI drivers" >> + >> +config USB_ULPI >> + bool >> + >> +config USB_ULPI_VIEWPORT >> + bool >> + >> +config USB_ULPI_VIEWPORT_OMAP >> + bool > > Description of these options is missing. My intention here was to keep it away from "users". This options are not "optional" in any way. They are rather like CPU_something or VBAR_something, that is - they are required and should be selected by drivers that use them, but without this drivers, they are useless. But maybe I'm missing something :) If anyone insists on that - I'll make them visible and add description. Regards, Mateusz -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWjuLGAAoJELvtohmVtQzBKT0H/RpJpIiXOrjLpAiQRL2V78t7 RUFiaCNolTHWqxerJ1JK4RqBiO9xn1Z8CWzAyxOkjt+fGUzjkkWjCJ4l5tDAcqpP BXPCPEMu4otOKN5LksUOBWDNIWyFuuvvDNS/tbQmPwosNCaUdKankxwbP4esoNuO t4ZpoDgcls9p73zTCYfcku6KR2viSEGabpvUT0YATmtc/2GdYfRjZYGjdEAF2Rug oEqDFX7tzVqgOtzWSoGdvA/qiUbLTqc4L2AyxWrMhgyl780bMaKzBCPtEQrAP/iD sc/ikXGB72I4Km5IhUoliDCZeJtxaPrpfZo1L7vOQ/WXQDGTcq7JWQhgKJ11dUw= =08ri -----END PGP SIGNATURE-----
On Thursday, January 07, 2016 at 11:12:27 PM, Mateusz Kulikowski wrote: > On 06.01.2016 21:49, Marek Vasut wrote: > > On Wednesday, January 06, 2016 at 07:21:17 PM, Mateusz Kulikowski wrote: > >> The following options can be now enabled via defconfig: > >> - CONFIG_USB_ULPI > >> - CONFIG_USB_ULPI_VIEWPORT > >> - CONFIG_USB_ULPI_VIEWPORT_OMAP > > [...] > > >> +++ b/drivers/usb/ulpi/Kconfig > >> @@ -0,0 +1,10 @@ > >> +comment "ULPI drivers" > >> + > >> +config USB_ULPI > >> + bool > >> + > >> +config USB_ULPI_VIEWPORT > >> + bool > >> + > >> +config USB_ULPI_VIEWPORT_OMAP > >> + bool > > > > Description of these options is missing. > > My intention here was to keep it away from "users". > > This options are not "optional" in any way. > They are rather like CPU_something or VBAR_something, > that is - they are required and should be selected by drivers that use > them, but without this drivers, they are useless. OK, so they're just options which are selected by drivers. Got it. All is good from my side then. > But maybe I'm missing something :) > If anyone insists on that - I'll make them visible and add description. > > > > Regards, > Mateusz Best regards, Marek Vasut
Hi, On 7 January 2016 at 15:12, Mateusz Kulikowski <mateusz.kulikowski@gmail.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 06.01.2016 21:49, Marek Vasut wrote: >> On Wednesday, January 06, 2016 at 07:21:17 PM, Mateusz Kulikowski wrote: >>> The following options can be now enabled via defconfig: >>> - CONFIG_USB_ULPI >>> - CONFIG_USB_ULPI_VIEWPORT >>> - CONFIG_USB_ULPI_VIEWPORT_OMAP >>> > [...] > >>> +++ b/drivers/usb/ulpi/Kconfig >>> @@ -0,0 +1,10 @@ >>> +comment "ULPI drivers" >>> + >>> +config USB_ULPI >>> + bool >>> + >>> +config USB_ULPI_VIEWPORT >>> + bool >>> + >>> +config USB_ULPI_VIEWPORT_OMAP >>> + bool >> >> Description of these options is missing. > > My intention here was to keep it away from "users". > > This options are not "optional" in any way. > They are rather like CPU_something or VBAR_something, > that is - they are required and should be selected by drivers that use them, > but without this drivers, they are useless. Perhaps we don't need the options at all then? But there are lots of users in the tree. You should use the moveconfig.py script to move them all to Kconfig. > > But maybe I'm missing something :) > If anyone insists on that - I'll make them visible and add description. Please add detailed help for all Kconfig options you add. > Regards, Simon
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 08.01.2016 00:18, Simon Glass wrote: > Hi, > > On 7 January 2016 at 15:12, Mateusz Kulikowski [...] >>> On Wednesday, January 06, 2016 at 07:21:17 PM, Mateusz Kulikowski wrote: >>>> The following options can be now enabled via defconfig: >>>> - CONFIG_USB_ULPI >>>> - CONFIG_USB_ULPI_VIEWPORT >>>> - CONFIG_USB_ULPI_VIEWPORT_OMAP >>>> >> [...] >> >>>> +++ b/drivers/usb/ulpi/Kconfig >>>> @@ -0,0 +1,10 @@ >>>> +comment "ULPI drivers" >>>> + >>>> +config USB_ULPI >>>> + bool >>>> + >>>> +config USB_ULPI_VIEWPORT >>>> + bool >>>> + >>>> +config USB_ULPI_VIEWPORT_OMAP >>>> + bool >>> >>> Description of these options is missing. >> >> My intention here was to keep it away from "users". >> >> This options are not "optional" in any way. >> They are rather like CPU_something or VBAR_something, >> that is - they are required and should be selected by drivers that use them, >> but without this drivers, they are useless. > > Perhaps we don't need the options at all then? > > But there are lots of users in the tree. You should use the > moveconfig.py script to move them all to Kconfig. > >> >> But maybe I'm missing something :) >> If anyone insists on that - I'll make them visible and add description. > > Please add detailed help for all Kconfig options you add. Will add descriptions as big as I'm able to. Regards, Mateusz
diff --git a/drivers/usb/Kconfig b/drivers/usb/Kconfig index abb06fc..57b99f2 100644 --- a/drivers/usb/Kconfig +++ b/drivers/usb/Kconfig @@ -53,6 +53,8 @@ source "drivers/usb/musb-new/Kconfig" source "drivers/usb/emul/Kconfig" +source "drivers/usb/ulpi/Kconfig" + comment "USB peripherals" config USB_STORAGE diff --git a/drivers/usb/ulpi/Kconfig b/drivers/usb/ulpi/Kconfig new file mode 100644 index 0000000..f3210bc --- /dev/null +++ b/drivers/usb/ulpi/Kconfig @@ -0,0 +1,10 @@ +comment "ULPI drivers" + +config USB_ULPI + bool + +config USB_ULPI_VIEWPORT + bool + +config USB_ULPI_VIEWPORT_OMAP + bool
The following options can be now enabled via defconfig: - CONFIG_USB_ULPI - CONFIG_USB_ULPI_VIEWPORT - CONFIG_USB_ULPI_VIEWPORT_OMAP Signed-off-by: Mateusz Kulikowski <mateusz.kulikowski@gmail.com> --- Changes in v1: New patch drivers/usb/Kconfig | 2 ++ drivers/usb/ulpi/Kconfig | 10 ++++++++++ 2 files changed, 12 insertions(+) create mode 100644 drivers/usb/ulpi/Kconfig