diff mbox

[U-Boot,3/3] test/py: add a test for the sleep command

Message ID 1452101585-25933-3-git-send-email-swarren@wwwdotorg.org
State Accepted
Commit 1c8b4d5f4f6a8bad12b2b690a04f96731410bb73
Delegated to: Simon Glass
Headers show

Commit Message

Stephen Warren Jan. 6, 2016, 5:33 p.m. UTC
From: Stephen Warren <swarren@nvidia.com>

Execute "sleep", and validate that it sleeps for approximately the correct
amount of time.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
This patch depends on both the two previous patches, and on my unrelated
series which adds the test/py code. If I resend that series, I can add
this patch into it.
---
 test/py/tests/test_sleep.py | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)
 create mode 100644 test/py/tests/test_sleep.py

Comments

Simon Glass Jan. 11, 2016, 3:23 p.m. UTC | #1
On 6 January 2016 at 10:33, Stephen Warren <swarren@wwwdotorg.org> wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Execute "sleep", and validate that it sleeps for approximately the correct
> amount of time.
>
> Signed-off-by: Stephen Warren <swarren@nvidia.com>
> ---
> This patch depends on both the two previous patches, and on my unrelated
> series which adds the test/py code. If I resend that series, I can add
> this patch into it.
> ---
>  test/py/tests/test_sleep.py | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 test/py/tests/test_sleep.py

Acked-by: Simon Glass <sjg@chromium.org>
Stephen Warren Jan. 15, 2016, 6:24 p.m. UTC | #2
On 01/06/2016 10:33 AM, Stephen Warren wrote:
> From: Stephen Warren <swarren@nvidia.com>
>
> Execute "sleep", and validate that it sleeps for approximately the correct
> amount of time.

FYI, I've reposted the series that implements the test/py code, and 
bundled this patch 3/3 in this series into that series.

As such, I believe patches 1/3 and 2/3 in this series can be applied 
through whatever path sandbox (or DM or timer) patches would normally go 
through.
Simon Glass Jan. 21, 2016, 2:16 a.m. UTC | #3
Hi Stephen,

On 15 January 2016 at 11:24, Stephen Warren <swarren@wwwdotorg.org> wrote:
> On 01/06/2016 10:33 AM, Stephen Warren wrote:
>>
>> From: Stephen Warren <swarren@nvidia.com>
>>
>> Execute "sleep", and validate that it sleeps for approximately the correct
>> amount of time.
>
>
> FYI, I've reposted the series that implements the test/py code, and bundled
> this patch 3/3 in this series into that series.
>
> As such, I believe patches 1/3 and 2/3 in this series can be applied through
> whatever path sandbox (or DM or timer) patches would normally go through.

I've applied them to u-boot-dm.

Regards,
Simon
diff mbox

Patch

diff --git a/test/py/tests/test_sleep.py b/test/py/tests/test_sleep.py
new file mode 100644
index 000000000000..64f1ddf9a09f
--- /dev/null
+++ b/test/py/tests/test_sleep.py
@@ -0,0 +1,24 @@ 
+# Copyright (c) 2016, NVIDIA CORPORATION. All rights reserved.
+#
+# SPDX-License-Identifier: GPL-2.0
+
+import pytest
+import time
+
+def test_sleep(u_boot_console):
+    '''Test the sleep command, and validate that it sleeps for approximately
+    the correct amount of time.'''
+
+    # Do this before we time anything, to make sure U-Boot is already running.
+    # Otherwise, the system boot time is included in the time measurement.
+    u_boot_console.ensure_spawned()
+
+    # 3s isn't too long, but is enough to cross a few second boundaries.
+    sleep_time = 3
+    tstart = time.time()
+    u_boot_console.run_command('sleep %d' % sleep_time)
+    tend = time.time()
+    elapsed = tend - tstart
+    delta_to_expected = abs(elapsed - sleep_time)
+    # 0.25s margin is hopefully enough to account for any system overhead.
+    assert delta_to_expected < 0.25