| Message ID | 1450097109-30186-2-git-send-email-thomas@wytron.com.tw |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On 12/14/2015 05:45 AM, Thomas Chou wrote: > Zap the rockchip serial compatible string, because rockchip > serial has "snps,dw-apb-uart" compatible string in the dts. More importantly, the rockchip compatible value isn't defined in the binding.
On 14 December 2015 at 05:45, Thomas Chou <thomas@wytron.com.tw> wrote: > Zap the rockchip serial compatible string, because rockchip > serial has "snps,dw-apb-uart" compatible string in the dts. > > Signed-off-by: Thomas Chou <thomas@wytron.com.tw> > --- > drivers/serial/ns16550.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Acked-by: Simon Glass <sjg@chromium.org>
On Mon, Dec 14, 2015 at 08:45:09PM +0800, Thomas Chou wrote: > Zap the rockchip serial compatible string, because rockchip > serial has "snps,dw-apb-uart" compatible string in the dts. > > Signed-off-by: Thomas Chou <thomas@wytron.com.tw> > Acked-by: Simon Glass <sjg@chromium.org> Applied to u-boot/master, thanks!
diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c index 3fab3f1..06ac005 100644 --- a/drivers/serial/ns16550.c +++ b/drivers/serial/ns16550.c @@ -424,11 +424,15 @@ const struct dm_serial_ops ns16550_serial_ops = { }; #if CONFIG_IS_ENABLED(OF_CONTROL) +/* + * Please consider existing compatible strings before adding a new + * one to keep this table compact. Or you may add a generic "ns16550" + * compatible string to your dts. + */ static const struct udevice_id ns16550_serial_ids[] = { { .compatible = "ns16550" }, { .compatible = "ns16550a" }, { .compatible = "nvidia,tegra20-uart" }, - { .compatible = "rockchip,rk3036-uart" }, { .compatible = "snps,dw-apb-uart" }, { .compatible = "ti,omap2-uart" }, { .compatible = "ti,omap3-uart" },
Zap the rockchip serial compatible string, because rockchip serial has "snps,dw-apb-uart" compatible string in the dts. Signed-off-by: Thomas Chou <thomas@wytron.com.tw> --- drivers/serial/ns16550.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)