diff mbox

[U-Boot,002/159] arm: mx6: Reduce SPL malloc pool size

Message ID 1449457640-3055-2-git-send-email-hl@rock-chips.com
State Not Applicable
Headers show

Commit Message

Lin Huang Dec. 7, 2015, 3:04 a.m. UTC 
From: Marek Vasut <marex@denx.de>

Using 50 MiB malloc pool in SPL is nonsense. Since the caches are not
enabled in SPL, it takes 2 seconds to init the pool and has no obvious
benefit. Reduce the size to 1 MiB.

Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Tim Harvey <tharvey@gateworks.com>
Tested-by: Stefano Babic <sbabic@denx.de>
Acked-by: Tim Harvey <tharvey@gateworks.com>
---
 include/configs/imx6_spl.h | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Stefano Babic Dec. 7, 2015, 8:14 a.m. UTC | #1 
Hi Lin,

On 07/12/2015 04:04, Lin Huang wrote:
> From: Marek Vasut <marex@denx.de>
> 
> Using 50 MiB malloc pool in SPL is nonsense. Since the caches are not
> enabled in SPL, it takes 2 seconds to init the pool and has no obvious
> benefit. Reduce the size to 1 MiB.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tim Harvey <tharvey@gateworks.com>
> Tested-by: Stefano Babic <sbabic@denx.de>
> Acked-by: Tim Harvey <tharvey@gateworks.com>
> ---
>  include/configs/imx6_spl.h | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h
> index 1744f2c..43ce7fe 100644
> --- a/include/configs/imx6_spl.h
> +++ b/include/configs/imx6_spl.h
> @@ -63,15 +63,15 @@
>  
>  #if defined(CONFIG_MX6SX) || defined(CONFIG_MX6UL) || defined(CONFIG_MX6SL)
>  #define CONFIG_SPL_BSS_START_ADDR      0x88200000
> -#define CONFIG_SPL_BSS_MAX_SIZE        0x100000        /* 1 MB */
> +#define CONFIG_SPL_BSS_MAX_SIZE        0x100000		/* 1 MB */
>  #define CONFIG_SYS_SPL_MALLOC_START    0x88300000
> -#define CONFIG_SYS_SPL_MALLOC_SIZE     0x3200000       /* 50 MB */
> +#define CONFIG_SYS_SPL_MALLOC_SIZE     0x100000		/* 1 MB */
>  #define CONFIG_SYS_TEXT_BASE           0x87800000
>  #else
>  #define CONFIG_SPL_BSS_START_ADDR	0x18200000
>  #define CONFIG_SPL_BSS_MAX_SIZE		0x100000	/* 1 MB */
>  #define CONFIG_SYS_SPL_MALLOC_START	0x18300000
> -#define CONFIG_SYS_SPL_MALLOC_SIZE	0x3200000	/* 50 MB */
> +#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
>  #define CONFIG_SYS_TEXT_BASE		0x17800000
>  #endif
>  #endif
> 

Marek's patch was already accepted and it is mainline. Which is the
reason to post it again ?

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/include/configs/imx6_spl.h b/include/configs/imx6_spl.h
index 1744f2c..43ce7fe 100644
--- a/include/configs/imx6_spl.h
+++ b/include/configs/imx6_spl.h
@@ -63,15 +63,15 @@ 
 
 #if defined(CONFIG_MX6SX) || defined(CONFIG_MX6UL) || defined(CONFIG_MX6SL)
 #define CONFIG_SPL_BSS_START_ADDR      0x88200000
-#define CONFIG_SPL_BSS_MAX_SIZE        0x100000        /* 1 MB */
+#define CONFIG_SPL_BSS_MAX_SIZE        0x100000		/* 1 MB */
 #define CONFIG_SYS_SPL_MALLOC_START    0x88300000
-#define CONFIG_SYS_SPL_MALLOC_SIZE     0x3200000       /* 50 MB */
+#define CONFIG_SYS_SPL_MALLOC_SIZE     0x100000		/* 1 MB */
 #define CONFIG_SYS_TEXT_BASE           0x87800000
 #else
 #define CONFIG_SPL_BSS_START_ADDR	0x18200000
 #define CONFIG_SPL_BSS_MAX_SIZE		0x100000	/* 1 MB */
 #define CONFIG_SYS_SPL_MALLOC_START	0x18300000
-#define CONFIG_SYS_SPL_MALLOC_SIZE	0x3200000	/* 50 MB */
+#define CONFIG_SYS_SPL_MALLOC_SIZE	0x100000	/* 1 MB */
 #define CONFIG_SYS_TEXT_BASE		0x17800000
 #endif
 #endif