| Message ID | 1445624047-6592-1-git-send-email-pftbest@gmail.com |
|---|---|
| State | Accepted |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
Hello Vadzim, On Fri, 23 Oct 2015 21:14:06 +0300, Vadzim Dambrouski <pftbest@gmail.com> wrote: > flash_lock call is inside a for loop, so after the first iteration flash > is locked and no more sectors can be erased. > Move flash_lock out of the loop. > > Signed-off-by: Vadzim Dambrouski <pftbest@gmail.com> > --- The history wrt v1 is missing in both patches. Can you repost v2 with history? In case you don't use it already, patman (see tools/patman/README) can ease the workload of managing the history of a patch or patch series. Amicalement,
diff --git a/arch/arm/cpu/armv7m/stm32f4/flash.c b/arch/arm/cpu/armv7m/stm32f4/flash.c index e5c6111..ae63790 100644 --- a/arch/arm/cpu/armv7m/stm32f4/flash.c +++ b/arch/arm/cpu/armv7m/stm32f4/flash.c @@ -114,9 +114,9 @@ int flash_erase(flash_info_t *info, int first, int last) ; clrbits_le32(&STM32_FLASH->cr, STM32_FLASH_CR_SER); - stm32f4_flash_lock(1); } + stm32f4_flash_lock(1); return 0; }
flash_lock call is inside a for loop, so after the first iteration flash is locked and no more sectors can be erased. Move flash_lock out of the loop. Signed-off-by: Vadzim Dambrouski <pftbest@gmail.com> --- arch/arm/cpu/armv7m/stm32f4/flash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)