| Message ID | 1445592238-2129-1-git-send-email-josh.wu@atmel.com |
|---|---|
| State | Accepted, archived |
| Delegated to: | Andreas Bießmann |
| Headers | show |
On 23 October 2015 at 03:23, Josh Wu <josh.wu@atmel.com> wrote: > crt0.S do both memset the bss section and call board_init_r for us, so > remove them from board_init_f(). > > Signed-off-by: Josh Wu <josh.wu@atmel.com> > --- > > arch/arm/mach-at91/spl_atmel.c | 5 ----- > 1 file changed, 5 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On 23.10.15 11:23, Josh Wu wrote: > crt0.S do both memset the bss section and call board_init_r for us, so > remove them from board_init_f(). > > Signed-off-by: Josh Wu <josh.wu@atmel.com> Reviewed-by: Andreas Bießmann <andreas.devel@googlemail.com> > --- > > arch/arm/mach-at91/spl_atmel.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm/mach-at91/spl_atmel.c b/arch/arm/mach-at91/spl_atmel.c > index 8ac5335..b2fb51d 100644 > --- a/arch/arm/mach-at91/spl_atmel.c > +++ b/arch/arm/mach-at91/spl_atmel.c > @@ -98,9 +98,4 @@ void board_init_f(ulong dummy) > preloader_console_init(); > > mem_init(); > - > - /* Clear the BSS. */ > - memset(__bss_start, 0, __bss_end - __bss_start); > - > - board_init_r(NULL, 0); > } >
Dear Josh Wu, Josh Wu <josh.wu@atmel.com> writes: >crt0.S do both memset the bss section and call board_init_r for us, so >remove them from board_init_f(). > >Signed-off-by: Josh Wu <josh.wu@atmel.com> >Reviewed-by: Simon Glass <sjg@chromium.org> >Reviewed-by: Andreas Bießmann <andreas.devel@googlemail.com> >--- > > arch/arm/mach-at91/spl_atmel.c | 5 ----- > 1 file changed, 5 deletions(-) applied to u-boot-atmel/master, thanks! Best regards, Andreas Bießmann
diff --git a/arch/arm/mach-at91/spl_atmel.c b/arch/arm/mach-at91/spl_atmel.c index 8ac5335..b2fb51d 100644 --- a/arch/arm/mach-at91/spl_atmel.c +++ b/arch/arm/mach-at91/spl_atmel.c @@ -98,9 +98,4 @@ void board_init_f(ulong dummy) preloader_console_init(); mem_init(); - - /* Clear the BSS. */ - memset(__bss_start, 0, __bss_end - __bss_start); - - board_init_r(NULL, 0); }
crt0.S do both memset the bss section and call board_init_r for us, so remove them from board_init_f(). Signed-off-by: Josh Wu <josh.wu@atmel.com> --- arch/arm/mach-at91/spl_atmel.c | 5 ----- 1 file changed, 5 deletions(-)