diff mbox

[U-Boot] patman: use -D option for git format-patch

Message ID 1439865029-7953-1-git-send-email-yamada.masahiro@socionext.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Masahiro Yamada Aug. 18, 2015, 2:30 a.m. UTC
This allows Patman to generate smaller patches for file removal.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 tools/patman/gitutil.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Simon Glass Aug. 18, 2015, 3:45 a.m. UTC | #1
On 17 August 2015 at 20:30, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> This allows Patman to generate smaller patches for file removal.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  tools/patman/gitutil.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Simon Glass <sjg@chromium.org>
Heiko Schocher Aug. 18, 2015, 4:37 a.m. UTC | #2
Hello Masahiro,

Am 18.08.2015 um 04:30 schrieb Masahiro Yamada:
> This allows Patman to generate smaller patches for file removal.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>   tools/patman/gitutil.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thanks!

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
Simon Glass Aug. 22, 2015, 4:20 a.m. UTC | #3
Hi,

On 17 August 2015 at 22:37, Heiko Schocher <hs@denx.de> wrote:
> Hello Masahiro,
>
> Am 18.08.2015 um 04:30 schrieb Masahiro Yamada:
>>
>> This allows Patman to generate smaller patches for file removal.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>   tools/patman/gitutil.py | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> Thanks!
>
> Acked-by: Heiko Schocher <hs@denx.de>

I'm picking this up now since I think the current behaviour is actually wrong.

Applied to u-boot-x86, thanks!
diff mbox

Patch

diff --git a/tools/patman/gitutil.py b/tools/patman/gitutil.py
index 9e739d8..67b086b 100644
--- a/tools/patman/gitutil.py
+++ b/tools/patman/gitutil.py
@@ -264,7 +264,7 @@  def CreatePatches(start, count, series):
     """
     if series.get('version'):
         version = '%s ' % series['version']
-    cmd = ['git', 'format-patch', '-M', '--signoff']
+    cmd = ['git', 'format-patch', '-D', '-M', '--signoff']
     if series.get('cover'):
         cmd.append('--cover-letter')
     prefix = series.GetPatchPrefix()