diff mbox

[U-Boot] ppc4xx: Convert lwmon5 board to generic board

Message ID 1439461781-11270-1-git-send-email-sr@denx.de
State Changes Requested
Delegated to: Tom Rini
Headers show

Commit Message

Stefan Roese Aug. 13, 2015, 10:29 a.m. UTC
Add CONFIG_SYS_GENERIC_BOARD to lwmon5.h and CONFIG_DISPLAY_BOARDINFO
to Kconfig file.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
---
 board/lwmon5/Kconfig     | 4 ++++
 include/configs/lwmon5.h | 2 ++
 2 files changed, 6 insertions(+)

Comments

Tom Rini Aug. 14, 2015, 8:24 p.m. UTC | #1
On Thu, Aug 13, 2015 at 12:29:41PM +0200, Stefan Roese wrote:

> Add CONFIG_SYS_GENERIC_BOARD to lwmon5.h and CONFIG_DISPLAY_BOARDINFO
> to Kconfig file.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>

With this:
+(lcd4_lwmon5) arch/powerpc/cpu/ppc4xx/start.o: In function `_start':
+(lcd4_lwmon5) build/../arch/powerpc/cpu/ppc4xx/start.S:765: undefined
reference to `board_init_f_mem'
Stefan Roese Aug. 17, 2015, 6:39 a.m. UTC | #2
Hi Tom,

On 14.08.2015 22:24, Tom Rini wrote:
> On Thu, Aug 13, 2015 at 12:29:41PM +0200, Stefan Roese wrote:
>
>> Add CONFIG_SYS_GENERIC_BOARD to lwmon5.h and CONFIG_DISPLAY_BOARDINFO
>> to Kconfig file.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
>
> With this:
> +(lcd4_lwmon5) arch/powerpc/cpu/ppc4xx/start.o: In function `_start':
> +(lcd4_lwmon5) build/../arch/powerpc/cpu/ppc4xx/start.S:765: undefined
> reference to `board_init_f_mem'

Ah, right. The lcd4_lwmon5 variant enables SPL and is not converted to 
generic-board this easily. Fixing this will most likely need a bit more 
work, so lets remove lwmon5 now. And once I find the time to fix this, 
I'll add it back in.

Thanks,
Stefan
diff mbox

Patch

diff --git a/board/lwmon5/Kconfig b/board/lwmon5/Kconfig
index 90566d8..7b8c605 100644
--- a/board/lwmon5/Kconfig
+++ b/board/lwmon5/Kconfig
@@ -6,4 +6,8 @@  config SYS_BOARD
 config SYS_CONFIG_NAME
 	default "lwmon5"
 
+config DISPLAY_BOARDINFO
+	bool
+	default y
+
 endif
diff --git a/include/configs/lwmon5.h b/include/configs/lwmon5.h
index 513167e..2a50bfe 100644
--- a/include/configs/lwmon5.h
+++ b/include/configs/lwmon5.h
@@ -23,6 +23,8 @@ 
 #define CONFIG_440EPX		1		/* Specific PPC440EPx	*/
 #define CONFIG_440		1		/* ... PPC440 family	*/
 
+#define CONFIG_SYS_GENERIC_BOARD
+
 #ifdef CONFIG_LCD4_LWMON5
 #define	CONFIG_SYS_TEXT_BASE	0x01000000 /* SPL U-Boot TEXT_BASE */
 #define CONFIG_HOSTNAME		lcd4_lwmon5