diff mbox

[U-Boot,5/5] include: configs: am43xx_evm: add 'usb stop' in usbboot env

Message ID 1439205778-14343-6-git-send-email-kishon@ti.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Kishon Vijay Abraham I Aug. 10, 2015, 11:22 a.m. UTC
The usbboot environment variable has 'usb start' command but
doesn't have the corresponding 'usb stop' command. This breaks
usb peripheral mode if tried after 'run usbboot' fails to load
the images in usb host mode.

Fix it here by adding 'usb stop' command in usbboot env.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 include/configs/am43xx_evm.h |    2 ++
 1 file changed, 2 insertions(+)

Comments

Tom Rini Aug. 11, 2015, 12:33 a.m. UTC | #1
On Mon, Aug 10, 2015 at 04:52:58PM +0530, Kishon Vijay Abraham I wrote:

> The usbboot environment variable has 'usb start' command but
> doesn't have the corresponding 'usb stop' command. This breaks
> usb peripheral mode if tried after 'run usbboot' fails to load
> the images in usb host mode.
> 
> Fix it here by adding 'usb stop' command in usbboot env.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>
Tom Rini Aug. 28, 2015, 9:04 p.m. UTC | #2
On Mon, Aug 10, 2015 at 04:52:58PM +0530, Kishon Vijay Abraham I wrote:

> The usbboot environment variable has 'usb start' command but
> doesn't have the corresponding 'usb stop' command. This breaks
> usb peripheral mode if tried after 'run usbboot' fails to load
> the images in usb host mode.
> 
> Fix it here by adding 'usb stop' command in usbboot env.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/include/configs/am43xx_evm.h b/include/configs/am43xx_evm.h
index d148169..15fa3e3 100644
--- a/include/configs/am43xx_evm.h
+++ b/include/configs/am43xx_evm.h
@@ -292,6 +292,8 @@ 
 				"bootz ${loadaddr} - ${fdtaddr}; " \
 			"fi;" \
 		"fi\0" \
+		"fi;" \
+		"usb stop ${usbdev};\0" \
 	"findfdt="\
 		"if test $board_name = AM43EPOS; then " \
 			"setenv fdtfile am43x-epos-evm.dtb; fi; " \