| Message ID | 1439205351-14092-4-git-send-email-kishon@ti.com |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
On Monday, August 10, 2015 at 01:15:51 PM, Kishon Vijay Abraham I wrote: > populate _reset_ callback to the USB ethernet gadget since UDC core > expects every gadget driver to have the reset callback. This shouldn't > be needed once the ethernet gadget driver is adapted to use the > composite driver. > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > --- > drivers/usb/gadget/ether.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c > index 850ba02..53f4672 100644 > --- a/drivers/usb/gadget/ether.c > +++ b/drivers/usb/gadget/ether.c > @@ -2505,6 +2505,7 @@ static struct usb_gadget_driver eth_driver = { > .unbind = eth_unbind, > > .setup = eth_setup, > + .reset = eth_disconnect, > .disconnect = eth_disconnect, I'm not sure about this one, Lukasz, can you please comment ? > > .suspend = eth_suspend, Best regards, Marek Vasut
On Mon, Aug 10, 2015 at 04:45:51PM +0530, Kishon Vijay Abraham I wrote: > populate _reset_ callback to the USB ethernet gadget since UDC core > expects every gadget driver to have the reset callback. This shouldn't > be needed once the ethernet gadget driver is adapted to use the > composite driver. > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Reviewed-by: Tom Rini <trini@konsulko.com>
Hi Marek, > On Monday, August 10, 2015 at 01:15:51 PM, Kishon Vijay Abraham I > wrote: > > populate _reset_ callback to the USB ethernet gadget since UDC core > > expects every gadget driver to have the reset callback. This > > shouldn't be needed once the ethernet gadget driver is adapted to > > use the composite driver. > > > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > > --- > > drivers/usb/gadget/ether.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c > > index 850ba02..53f4672 100644 > > --- a/drivers/usb/gadget/ether.c > > +++ b/drivers/usb/gadget/ether.c > > @@ -2505,6 +2505,7 @@ static struct usb_gadget_driver eth_driver = { > > .unbind = eth_unbind, > > > > .setup = eth_setup, > > + .reset = eth_disconnect, > > .disconnect = eth_disconnect, > > I'm not sure about this one, Lukasz, can you please comment ? This is correct. > > > > > .suspend = eth_suspend, > > Best regards, > Marek Vasut Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
diff --git a/drivers/usb/gadget/ether.c b/drivers/usb/gadget/ether.c index 850ba02..53f4672 100644 --- a/drivers/usb/gadget/ether.c +++ b/drivers/usb/gadget/ether.c @@ -2505,6 +2505,7 @@ static struct usb_gadget_driver eth_driver = { .unbind = eth_unbind, .setup = eth_setup, + .reset = eth_disconnect, .disconnect = eth_disconnect, .suspend = eth_suspend,
populate _reset_ callback to the USB ethernet gadget since UDC core expects every gadget driver to have the reset callback. This shouldn't be needed once the ethernet gadget driver is adapted to use the composite driver. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- drivers/usb/gadget/ether.c | 1 + 1 file changed, 1 insertion(+)