| Message ID | 1439126357-23842-2-git-send-email-christophe-h.ricard@st.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Simon Glass |
| Headers | show |
On 9 August 2015 at 07:19, Christophe Ricard <christophe.ricard@gmail.com> wrote: > As there is no TCG specification or recommendation for i2c TPM 1.2, move > tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like atmel or > stmicroelectronics may have a different transport protocol for i2c. > > Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com> > --- > > README | 4 ++-- > drivers/tpm/Makefile | 2 +- > drivers/tpm/{tpm_tis_i2c.c => tpm_i2c_infineon.c} | 0 > 3 files changed, 3 insertions(+), 3 deletions(-) > rename drivers/tpm/{tpm_tis_i2c.c => tpm_i2c_infineon.c} (100%) Reviewed-by: Simon Glass <sjg@chromium.org>
Hi Chrisophe, On 13 August 2015 at 09:55, Simon Glass <sjg@chromium.org> wrote: > On 9 August 2015 at 07:19, Christophe Ricard > <christophe.ricard@gmail.com> wrote: >> As there is no TCG specification or recommendation for i2c TPM 1.2, move >> tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like atmel or >> stmicroelectronics may have a different transport protocol for i2c. >> >> Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com> >> --- >> >> README | 4 ++-- >> drivers/tpm/Makefile | 2 +- >> drivers/tpm/{tpm_tis_i2c.c => tpm_i2c_infineon.c} | 0 >> 3 files changed, 3 insertions(+), 3 deletions(-) >> rename drivers/tpm/{tpm_tis_i2c.c => tpm_i2c_infineon.c} (100%) > > Reviewed-by: Simon Glass <sjg@chromium.org> Can you please take another look at this patch? You need to change existing users of this config to use your renamed Kconfig. This means updating things in the configs/ directory. Regards, Simon
Hi Simon, Apologies for the delay. I will try to rework this patch end of this week and send it back to you middle of next week. Best Regards Christophe Le 31/08/2015 00:45, Simon Glass a écrit : > Hi Chrisophe, > > On 13 August 2015 at 09:55, Simon Glass <sjg@chromium.org> wrote: >> On 9 August 2015 at 07:19, Christophe Ricard >> <christophe.ricard@gmail.com> wrote: >>> As there is no TCG specification or recommendation for i2c TPM 1.2, move >>> tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like atmel or >>> stmicroelectronics may have a different transport protocol for i2c. >>> >>> Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com> >>> --- >>> >>> README | 4 ++-- >>> drivers/tpm/Makefile | 2 +- >>> drivers/tpm/{tpm_tis_i2c.c => tpm_i2c_infineon.c} | 0 >>> 3 files changed, 3 insertions(+), 3 deletions(-) >>> rename drivers/tpm/{tpm_tis_i2c.c => tpm_i2c_infineon.c} (100%) >> Reviewed-by: Simon Glass <sjg@chromium.org> > Can you please take another look at this patch? > > You need to change existing users of this config to use your renamed > Kconfig. This means updating things in the configs/ directory. > > Regards, > Simon
Hi Christophe, On 2 September 2015 at 11:54, Christophe Ricard <christophe.ricard@gmail.com> wrote: > Hi Simon, > > Apologies for the delay. I will try to rework this patch end of this week > and send it back to you middle of next week. OK thanks, sounds good. [snip] Regards, Simon
diff --git a/README b/README index 1bcb63c..a563aa1 100644 --- a/README +++ b/README @@ -1492,8 +1492,8 @@ The following options need to be configured: CONFIG_TPM Support TPM devices. - CONFIG_TPM_TIS_I2C - Support for i2c bus TPM devices. Only one device + CONFIG_TPM_I2C_INFINEON + Support for infineon i2c bus TPM devices. Only one device per system is supported at this time. CONFIG_TPM_TIS_I2C_BUS_NUMBER diff --git a/drivers/tpm/Makefile b/drivers/tpm/Makefile index 150570e..fea246f 100644 --- a/drivers/tpm/Makefile +++ b/drivers/tpm/Makefile @@ -6,6 +6,6 @@ # TODO: Merge tpm_tis_lpc.c with tpm.c obj-$(CONFIG_TPM_ATMEL_TWI) += tpm_atmel_twi.o obj-$(CONFIG_TPM_TIS_I2C) += tpm.o -obj-$(CONFIG_TPM_TIS_I2C) += tpm_tis_i2c.o +obj-$(CONFIG_TPM_INFINEON_I2C) += tpm_i2c_infineon.o obj-$(CONFIG_TPM_TIS_LPC) += tpm_tis_lpc.o obj-$(CONFIG_TPM_TIS_SANDBOX) += tpm_tis_sandbox.o diff --git a/drivers/tpm/tpm_tis_i2c.c b/drivers/tpm/tpm_i2c_infineon.c similarity index 100% rename from drivers/tpm/tpm_tis_i2c.c rename to drivers/tpm/tpm_i2c_infineon.c
As there is no TCG specification or recommendation for i2c TPM 1.2, move tpm_tis_i2c driver to tpm_i2c_infineon. Other tpm vendors like atmel or stmicroelectronics may have a different transport protocol for i2c. Signed-off-by: Christophe Ricard <christophe-h.ricard@st.com> --- README | 4 ++-- drivers/tpm/Makefile | 2 +- drivers/tpm/{tpm_tis_i2c.c => tpm_i2c_infineon.c} | 0 3 files changed, 3 insertions(+), 3 deletions(-) rename drivers/tpm/{tpm_tis_i2c.c => tpm_i2c_infineon.c} (100%)