| Message ID | 1437913960-15456-1-git-send-email-sbabic@denx.de |
|---|---|
| State | Superseded |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Stefano On Sun, Jul 26, 2015 at 2:32 PM, Stefano Babic <sbabic@denx.de> wrote: > mcx was not updated according to changes in > NAND driver. > > Signed-off-by: Stefano Babic <sbabic@denx.de> > --- > include/configs/mcx.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/configs/mcx.h b/include/configs/mcx.h > index 0a7b7cf..d8766b9 100644 > --- a/include/configs/mcx.h > +++ b/include/configs/mcx.h > @@ -309,7 +309,10 @@ > */ > > /* **** PISMO SUPPORT *** */ > +#define CONFIG_NAND > +#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 Well the define name and the value is really funny ;) Michael > #define CONFIG_NAND_OMAP_GPMC > +#define CONFIG_NAND_OMAP_GPMC_PREFETCH > #define CONFIG_ENV_IS_IN_NAND > #define SMNAND_ENV_OFFSET 0x180000 /* environment starts here */ > > -- > 1.9.1 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
Hi Michael, On 26/07/2015 14:49, Michael Trimarchi wrote: > Hi Stefano > > On Sun, Jul 26, 2015 at 2:32 PM, Stefano Babic <sbabic@denx.de> wrote: >> mcx was not updated according to changes in >> NAND driver. >> >> Signed-off-by: Stefano Babic <sbabic@denx.de> >> --- >> include/configs/mcx.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/include/configs/mcx.h b/include/configs/mcx.h >> index 0a7b7cf..d8766b9 100644 >> --- a/include/configs/mcx.h >> +++ b/include/configs/mcx.h >> @@ -309,7 +309,10 @@ >> */ >> >> /* **** PISMO SUPPORT *** */ >> +#define CONFIG_NAND >> +#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > > Well the define name and the value is really funny ;) > You're right - funnier is that is common (I copied & paste from another board): include/configs/omap3_beagle.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/am3517_crane.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/omap3_zoom1.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/omap3_overo.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/dig297.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/dra7xx_evm.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT include/configs/omap3_igep00x0.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/omap3_logic.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/tt01.h: * #define CONFIG_SYS_NAND_BUSWIDTH_16BIT include/configs/omap3_pandora.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/tao3530.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/devkit8000.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/tam3517-common.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 include/configs/omap3_evm_common.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 I drop it in V2, thanks. Stefano
Hi On Sun, Jul 26, 2015 at 3:04 PM, Stefano Babic <sbabic@denx.de> wrote: > Hi Michael, > > On 26/07/2015 14:49, Michael Trimarchi wrote: >> Hi Stefano >> >> On Sun, Jul 26, 2015 at 2:32 PM, Stefano Babic <sbabic@denx.de> wrote: >>> mcx was not updated according to changes in >>> NAND driver. >>> >>> Signed-off-by: Stefano Babic <sbabic@denx.de> >>> --- >>> include/configs/mcx.h | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/include/configs/mcx.h b/include/configs/mcx.h >>> index 0a7b7cf..d8766b9 100644 >>> --- a/include/configs/mcx.h >>> +++ b/include/configs/mcx.h >>> @@ -309,7 +309,10 @@ >>> */ >>> >>> /* **** PISMO SUPPORT *** */ >>> +#define CONFIG_NAND >>> +#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 >> >> Well the define name and the value is really funny ;) >> > > You're right - funnier is that is common (I copied & paste from another > board): > Please prepare even a cleanup patch for the other if you have time ;) Michael > include/configs/omap3_beagle.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/am3517_crane.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/omap3_zoom1.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/omap3_overo.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/dig297.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/dra7xx_evm.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT > include/configs/omap3_igep00x0.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/omap3_logic.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/tt01.h: * #define CONFIG_SYS_NAND_BUSWIDTH_16BIT > include/configs/omap3_pandora.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/tao3530.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/devkit8000.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/tam3517-common.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > include/configs/omap3_evm_common.h:#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 > > > I drop it in V2, thanks. > > Stefano > > -- > ===================================================================== > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de > =====================================================================
diff --git a/include/configs/mcx.h b/include/configs/mcx.h index 0a7b7cf..d8766b9 100644 --- a/include/configs/mcx.h +++ b/include/configs/mcx.h @@ -309,7 +309,10 @@ */ /* **** PISMO SUPPORT *** */ +#define CONFIG_NAND +#define CONFIG_SYS_NAND_BUSWIDTH_16BIT 16 #define CONFIG_NAND_OMAP_GPMC +#define CONFIG_NAND_OMAP_GPMC_PREFETCH #define CONFIG_ENV_IS_IN_NAND #define SMNAND_ENV_OFFSET 0x180000 /* environment starts here */
mcx was not updated according to changes in NAND driver. Signed-off-by: Stefano Babic <sbabic@denx.de> --- include/configs/mcx.h | 3 +++ 1 file changed, 3 insertions(+)