| Message ID | 1437811877-13764-9-git-send-email-l.majewski@majess.pl |
|---|---|
| State | Superseded |
| Delegated to: | Łukasz Majewski |
| Headers | show |
HI Lukasz, On 25 July 2015 at 02:11, Lukasz Majewski <l.majewski@majess.pl> wrote: Commit message? E.g. 'Enable DFU via update on Beaglebone Black' > Signed-off-by: Lukasz Majewski <l.majewski@majess.pl> > --- > Changes for v2: > - Do not enable CONFIG_UPDATE_TFTP since CONFIG_DFU_TFTP enables the common code > - Do not enable CONFIG_CMD_DFUTFTP since dfutftp commands has been removed > --- > include/configs/am335x_evm.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h > index 633391b..be000fa 100644 > --- a/include/configs/am335x_evm.h > +++ b/include/configs/am335x_evm.h > @@ -46,6 +46,14 @@ > #define CONFIG_CMD_GPT > #define CONFIG_EFI_PARTITION > > +/* Commands to enable DFU TFTP support */ > +#define CONFIG_DFU_TFTP Can this go in Kconfig and then the board's defconfig? > +#define CONFIG_OF_LIBFDT > + > +/* Enable SHA1 support */ > +#define CONFIG_SHA1 > +#define CONFIG_CMD_SHA1SUM > + > #ifdef CONFIG_NAND > #define NANDARGS \ > "mtdids=" MTDIDS_DEFAULT "\0" \ > -- > 2.1.4 > Regards, Simon
Hi Lukasz, On Sat, Jul 25, 2015 at 3:11 AM, Lukasz Majewski <l.majewski@majess.pl> wrote: > Signed-off-by: Lukasz Majewski <l.majewski@majess.pl> > --- > Changes for v2: > - Do not enable CONFIG_UPDATE_TFTP since CONFIG_DFU_TFTP enables the common code > - Do not enable CONFIG_CMD_DFUTFTP since dfutftp commands has been removed > --- I agree with Simon on his 2 points. Please address those.
diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h index 633391b..be000fa 100644 --- a/include/configs/am335x_evm.h +++ b/include/configs/am335x_evm.h @@ -46,6 +46,14 @@ #define CONFIG_CMD_GPT #define CONFIG_EFI_PARTITION +/* Commands to enable DFU TFTP support */ +#define CONFIG_DFU_TFTP +#define CONFIG_OF_LIBFDT + +/* Enable SHA1 support */ +#define CONFIG_SHA1 +#define CONFIG_CMD_SHA1SUM + #ifdef CONFIG_NAND #define NANDARGS \ "mtdids=" MTDIDS_DEFAULT "\0" \
Signed-off-by: Lukasz Majewski <l.majewski@majess.pl> --- Changes for v2: - Do not enable CONFIG_UPDATE_TFTP since CONFIG_DFU_TFTP enables the common code - Do not enable CONFIG_CMD_DFUTFTP since dfutftp commands has been removed --- include/configs/am335x_evm.h | 8 ++++++++ 1 file changed, 8 insertions(+)