| Message ID | 1437053801-23426-1-git-send-email-contact@paulk.fr |
|---|---|
| State | Accepted |
| Delegated to: | Tom Rini |
| Headers | show |
On Thu, Jul 16, 2015 at 03:36:41PM +0200, Paul Kocialkowski wrote: > All am33xx device tree are using device-tree, so get_board_rev is never actually > called. Thus, we can get rid of it to make the code easier to maintain. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> Reviewed-by: Tom Rini <trini@konsulko.com>
Le jeudi 16 juillet 2015 à 09:40 -0400, Tom Rini a écrit : > On Thu, Jul 16, 2015 at 03:36:41PM +0200, Paul Kocialkowski wrote: > > > All am33xx device tree are using device-tree, so get_board_rev is never actually > > called. Thus, we can get rid of it to make the code easier to maintain. > > > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > > Reviewed-by: Tom Rini <trini@konsulko.com> What about merging this patch? It's been more than a week since we last discussed it. Thanks!
On Thu, Jul 16, 2015 at 03:36:41PM +0200, Paul Kocialkowski wrote: > All am33xx device tree are using device-tree, so get_board_rev is never actually > called. Thus, we can get rid of it to make the code easier to maintain. > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr> > Reviewed-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
diff --git a/arch/arm/cpu/armv7/am33xx/sys_info.c b/arch/arm/cpu/armv7/am33xx/sys_info.c index 781d83f..52a6824 100644 --- a/arch/arm/cpu/armv7/am33xx/sys_info.c +++ b/arch/arm/cpu/armv7/am33xx/sys_info.c @@ -51,15 +51,6 @@ u32 get_cpu_type(void) } /** - * get_board_rev() - setup to pass kernel board revision information - * returns: 0 for the ATAG REVISION tag value. - */ -u32 __weak get_board_rev(void) -{ - return 0; -} - -/** * get_device_type(): tell if GP/HS/EMU/TST */ u32 get_device_type(void)
All am33xx device tree are using device-tree, so get_board_rev is never actually called. Thus, we can get rid of it to make the code easier to maintain. Signed-off-by: Paul Kocialkowski <contact@paulk.fr> --- arch/arm/cpu/armv7/am33xx/sys_info.c | 9 --------- 1 file changed, 9 deletions(-)