diff mbox

[U-Boot,RFC] patman: add distutils based installer

Message ID 1436954789-9825-1-git-send-email-judge.packham@gmail.com
State Superseded
Delegated to: Simon Glass
Headers show

Commit Message

Chris Packham July 15, 2015, 10:06 a.m. UTC
To make it easier to use patman on other projects add a distutils style
installer. Now patman can be installed with

  cd u-boot/tools/patman && python setup.py install

There are also the usual distutils options for creating source/binary
distributions of patman.

Signed-off-by: Chris Packham <judge.packham@gmail.com>
---
I've been playing with using patman for Linux development and it
occurred to me that patman should really be something that lives on my
default $PATH.

It's simple enough to create a distutils configuration that makes this a
reality.

One thing that would make sense for this is to make patman a python
package to avoid polluting site-packages with generic names like 'test'
and 'command'. With a little restructuring it would probably be possible
to setup something that works both as an installable package and in-tree
as it does today. But before I go down that path I wanted to see if
there was a desire for such packaging or do people just add
u-boot/tools/patman to their $PATH.

Thanks,
Chris

 tools/patman/setup.py | 11 +++++++++++
 1 file changed, 11 insertions(+)
 create mode 100644 tools/patman/setup.py

Comments

Otavio Salvador July 15, 2015, 8:31 p.m. UTC | #1
On Wed, Jul 15, 2015 at 7:06 AM, Chris Packham <judge.packham@gmail.com> wrote:
> To make it easier to use patman on other projects add a distutils style
> installer. Now patman can be installed with
>
>   cd u-boot/tools/patman && python setup.py install
>
> There are also the usual distutils options for creating source/binary
> distributions of patman.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> I've been playing with using patman for Linux development and it
> occurred to me that patman should really be something that lives on my
> default $PATH.
>
> It's simple enough to create a distutils configuration that makes this a
> reality.
>
> One thing that would make sense for this is to make patman a python
> package to avoid polluting site-packages with generic names like 'test'
> and 'command'. With a little restructuring it would probably be possible
> to setup something that works both as an installable package and in-tree
> as it does today. But before I go down that path I wanted to see if
> there was a desire for such packaging or do people just add
> u-boot/tools/patman to their $PATH.

yes, please!
Simon Glass July 16, 2015, 4:19 p.m. UTC | #2
On 15 July 2015 at 04:06, Chris Packham <judge.packham@gmail.com> wrote:
> To make it easier to use patman on other projects add a distutils style
> installer. Now patman can be installed with
>
>   cd u-boot/tools/patman && python setup.py install
>
> There are also the usual distutils options for creating source/binary
> distributions of patman.
>
> Signed-off-by: Chris Packham <judge.packham@gmail.com>
> ---
> I've been playing with using patman for Linux development and it
> occurred to me that patman should really be something that lives on my
> default $PATH.

That's what I do.

>
> It's simple enough to create a distutils configuration that makes this a
> reality.
>
> One thing that would make sense for this is to make patman a python
> package to avoid polluting site-packages with generic names like 'test'
> and 'command'. With a little restructuring it would probably be possible
> to setup something that works both as an installable package and in-tree
> as it does today. But before I go down that path I wanted to see if
> there was a desire for such packaging or do people just add
> u-boot/tools/patman to their $PATH.

I think it's a good idea, thanks for looking at it.

>
> Thanks,
> Chris
>
>  tools/patman/setup.py | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>  create mode 100644 tools/patman/setup.py

Acked-by: Simon Glass <sjg@chromium.org>

>
> diff --git a/tools/patman/setup.py b/tools/patman/setup.py
> new file mode 100644
> index 0000000..d14ac77
> --- /dev/null
> +++ b/tools/patman/setup.py
> @@ -0,0 +1,11 @@
> +#
> +# SPDX-License-Identifier:      GPL-2.0+
> +#
> +from distutils.core import setup
> +setup(name='patman',
> +      version='1.0',
> +      license='GPL-2.0+',
> +      scripts=['patman'],
> +      py_modules=['checkpatch', 'command', 'commit', 'cros_subprocess',
> +                  'get_maintainer', 'gitutil', 'patchstream', 'project',
> +                  'series', 'settings', 'terminal', 'test'])
> --
> 2.5.0.rc0
>
diff mbox

Patch

diff --git a/tools/patman/setup.py b/tools/patman/setup.py
new file mode 100644
index 0000000..d14ac77
--- /dev/null
+++ b/tools/patman/setup.py
@@ -0,0 +1,11 @@ 
+#
+# SPDX-License-Identifier:      GPL-2.0+
+#
+from distutils.core import setup
+setup(name='patman',
+      version='1.0',
+      license='GPL-2.0+',
+      scripts=['patman'],
+      py_modules=['checkpatch', 'command', 'commit', 'cros_subprocess',
+                  'get_maintainer', 'gitutil', 'patchstream', 'project',
+                  'series', 'settings', 'terminal', 'test'])