diff mbox

[U-Boot,2/2] blackfin: Fix build regression due to image size

Message ID 1435013858-1279-2-git-send-email-joe.hershberger@ni.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Joe Hershberger June 22, 2015, 10:57 p.m. UTC
bf533-stamp, bf538f-ezkit, and cm-bf548 are very space limited.

This was introduced by:
6e0d26c0502e (net: Handle ethaddr changes as an env callback)
by enabling CONFIG_REGEX, which is too big for these boards.

This patch disables CONFIG_REGEX at the expense of working with more
than the first ethaddr.

Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>

---

 configs/bf533-stamp_defconfig  | 1 +
 configs/bf538f-ezkit_defconfig | 1 +
 configs/cm-bf548_defconfig     | 1 +
 3 files changed, 3 insertions(+)

Comments

Joe Hershberger July 8, 2015, 4:38 a.m. UTC | #1
Hi Tom,

On Mon, Jun 22, 2015 at 5:57 PM, Joe Hershberger <joe.hershberger@ni.com> wrote:
> bf533-stamp, bf538f-ezkit, and cm-bf548 are very space limited.
>
> This was introduced by:
> 6e0d26c0502e (net: Handle ethaddr changes as an env callback)
> by enabling CONFIG_REGEX, which is too big for these boards.
>
> This patch disables CONFIG_REGEX at the expense of working with more
> than the first ethaddr.
>
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>
>
> ---

This is a build fix, so it should probably be part of v2015.07.

Cheers,
-Joe
Tom Rini July 10, 2015, 12:56 p.m. UTC | #2
On Mon, Jun 22, 2015 at 05:57:37PM -0500, Joe Hershberger wrote:

> bf533-stamp, bf538f-ezkit, and cm-bf548 are very space limited.
> 
> This was introduced by:
> 6e0d26c0502e (net: Handle ethaddr changes as an env callback)
> by enabling CONFIG_REGEX, which is too big for these boards.
> 
> This patch disables CONFIG_REGEX at the expense of working with more
> than the first ethaddr.
> 
> Signed-off-by: Joe Hershberger <joe.hershberger@ni.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/configs/bf533-stamp_defconfig b/configs/bf533-stamp_defconfig
index 154dc26..4956078 100644
--- a/configs/bf533-stamp_defconfig
+++ b/configs/bf533-stamp_defconfig
@@ -2,4 +2,5 @@  CONFIG_BLACKFIN=y
 CONFIG_TARGET_BF533_STAMP=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CC_OPTIMIZE_LIBS_FOR_SPEED=y
+# CONFIG_REGEX is not set
 CONFIG_LIB_RAND=y
diff --git a/configs/bf538f-ezkit_defconfig b/configs/bf538f-ezkit_defconfig
index 6cb6c6b..668f9cb 100644
--- a/configs/bf538f-ezkit_defconfig
+++ b/configs/bf538f-ezkit_defconfig
@@ -2,4 +2,5 @@  CONFIG_BLACKFIN=y
 CONFIG_TARGET_BF538F_EZKIT=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CC_OPTIMIZE_LIBS_FOR_SPEED=y
+# CONFIG_REGEX is not set
 CONFIG_LIB_RAND=y
diff --git a/configs/cm-bf548_defconfig b/configs/cm-bf548_defconfig
index 949612d..49d59dd 100644
--- a/configs/cm-bf548_defconfig
+++ b/configs/cm-bf548_defconfig
@@ -2,4 +2,5 @@  CONFIG_BLACKFIN=y
 CONFIG_TARGET_CM_BF548=y
 # CONFIG_CMD_SETEXPR is not set
 CONFIG_CC_OPTIMIZE_LIBS_FOR_SPEED=y
+# CONFIG_REGEX is not set
 CONFIG_LIB_RAND=y