| Message ID | 1433660284-10477-1-git-send-email-nikhil.badola@freescale.com |
|---|---|
| State | Accepted |
| Delegated to: | Marek Vasut |
| Headers | show |
On Sunday, June 07, 2015 at 08:58:04 AM, Nikhil Badola wrote: > Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller > to be initialised is incorrect This text doesn't really make much sense, but the fix is reasonable. I'll pick it, thanks! > Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> > --- > Changes for v2 > - Added space between tags in Subject > - Replaced return value from -1 to -EINVAL > > drivers/usb/host/ehci-fsl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c > index 5fd618d..97b7f14 100644 > --- a/drivers/usb/host/ehci-fsl.c > +++ b/drivers/usb/host/ehci-fsl.c > @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init, > break; > default: > printf("ERROR: wrong controller index!!\n"); > - break; > + return -EINVAL; > }; > > *hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength); Best regards, Marek Vasut
diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 5fd618d..97b7f14 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -76,7 +76,7 @@ int ehci_hcd_init(int index, enum usb_init_type init, break; default: printf("ERROR: wrong controller index!!\n"); - break; + return -EINVAL; }; *hccr = (struct ehci_hccr *)((uint32_t)&ehci->caplength);
Return if USB_MAX_CONTROLLER_COUNT hence the index of the controller to be initialised is incorrect Signed-off-by: Nikhil Badola <nikhil.badola@freescale.com> --- Changes for v2 - Added space between tags in Subject - Replaced return value from -1 to -EINVAL drivers/usb/host/ehci-fsl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)