| Message ID | 1425949977-20982-2-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Delegated to: | Tom Warren |
| Headers | show |
Let's try this: Reported-by: Stephen Warren <swarren@nvidia.com> On 9 March 2015 at 19:12, Simon Glass <sjg@chromium.org> wrote: > Requesting a GPIO without a name is not supposed anymore. This causes the > request to fail. Add a name so that the serial console works on seaboard. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > board/nvidia/seaboard/seaboard.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c > index 25480e4..2d07001 100644 > --- a/board/nvidia/seaboard/seaboard.c > +++ b/board/nvidia/seaboard/seaboard.c > @@ -20,7 +20,7 @@ > void gpio_early_init_uart(void) > { > /* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */ > - gpio_request(GPIO_PI3, NULL); > + gpio_request(GPIO_PI3, "uart_en"); > gpio_direction_output(GPIO_PI3, 0); > } > #endif > -- > 2.2.0.rc0.207.ga3a616c >
Hi Tom, On 9 March 2015 at 19:16, Simon Glass <sjg@chromium.org> wrote: > Let's try this: > > Reported-by: Stephen Warren <swarren@nvidia.com> > > > On 9 March 2015 at 19:12, Simon Glass <sjg@chromium.org> wrote: >> Requesting a GPIO without a name is not supposed anymore. This causes the >> request to fail. Add a name so that the serial console works on seaboard. >> >> Signed-off-by: Simon Glass <sjg@chromium.org> Can you please apply this fix? >> --- >> >> board/nvidia/seaboard/seaboard.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c >> index 25480e4..2d07001 100644 >> --- a/board/nvidia/seaboard/seaboard.c >> +++ b/board/nvidia/seaboard/seaboard.c >> @@ -20,7 +20,7 @@ >> void gpio_early_init_uart(void) >> { >> /* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */ >> - gpio_request(GPIO_PI3, NULL); >> + gpio_request(GPIO_PI3, "uart_en"); >> gpio_direction_output(GPIO_PI3, 0); >> } >> #endif >> -- >> 2.2.0.rc0.207.ga3a616c >> Regards, Simon
diff --git a/board/nvidia/seaboard/seaboard.c b/board/nvidia/seaboard/seaboard.c index 25480e4..2d07001 100644 --- a/board/nvidia/seaboard/seaboard.c +++ b/board/nvidia/seaboard/seaboard.c @@ -20,7 +20,7 @@ void gpio_early_init_uart(void) { /* Enable UART via GPIO_PI3 (port 8, bit 3) so serial console works */ - gpio_request(GPIO_PI3, NULL); + gpio_request(GPIO_PI3, "uart_en"); gpio_direction_output(GPIO_PI3, 0); } #endif
Requesting a GPIO without a name is not supposed anymore. This causes the request to fail. Add a name so that the serial console works on seaboard. Signed-off-by: Simon Glass <sjg@chromium.org> --- board/nvidia/seaboard/seaboard.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)