diff mbox

[U-Boot] lcd: fix console address is not initialized

Message ID 1422407602-18379-1-git-send-email-voice.shen@atmel.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Bo Shen Jan. 28, 2015, 1:13 a.m. UTC
This commit 904672e (lcd: refactor lcd console stuff into its
own file), which cause lcd console address is not initialized.

This patch initialize the lcd console use the default value,
will be update when splash screen is enabled.

Signed-off-by: Bo Shen <voice.shen@atmel.com>
---
Hi Tom,
  If no objection of this patch, can you apply it as soon as possible. 
Or else most Atmel SoC based boards (which enable lcd info) will be
broken.
  Thanks.

 common/lcd.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Anatolij Gustschin Jan. 29, 2015, 8:51 a.m. UTC | #1
Hi,

On Wed, 28 Jan 2015 09:13:22 +0800
Bo Shen <voice.shen@atmel.com> wrote:

> This commit 904672e (lcd: refactor lcd console stuff into its
> own file), which cause lcd console address is not initialized.
> 
> This patch initialize the lcd console use the default value,
> will be update when splash screen is enabled.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> Hi Tom,
>   If no objection of this patch, can you apply it as soon as possible. 
> Or else most Atmel SoC based boards (which enable lcd info) will be
> broken.
>   Thanks.
> 
>  common/lcd.c | 1 +
>  1 file changed, 1 insertion(+)

Slightly modified the commit log and applied to u-boot-video/master.

Thanks!

Anatolij
Bo Shen Jan. 29, 2015, 8:55 a.m. UTC | #2
Hi Anatolij,

On 01/29/2015 04:51 PM, Anatolij Gustschin wrote:
> Hi,
>
> On Wed, 28 Jan 2015 09:13:22 +0800
> Bo Shen <voice.shen@atmel.com> wrote:
>
>> This commit 904672e (lcd: refactor lcd console stuff into its
>> own file), which cause lcd console address is not initialized.
>>
>> This patch initialize the lcd console use the default value,
>> will be update when splash screen is enabled.
>>
>> Signed-off-by: Bo Shen <voice.shen@atmel.com>
>> ---
>> Hi Tom,
>>    If no objection of this patch, can you apply it as soon as possible.
>> Or else most Atmel SoC based boards (which enable lcd info) will be
>> broken.
>>    Thanks.
>>
>>   common/lcd.c | 1 +
>>   1 file changed, 1 insertion(+)
>
> Slightly modified the commit log and applied to u-boot-video/master.

Thanks.

> Thanks!
>
> Anatolij
>

Best Regards,
Bo Shen
Tom Rini Jan. 29, 2015, 2 p.m. UTC | #3
On Wed, Jan 28, 2015 at 09:13:22AM +0800, Bo Shen wrote:

> This commit 904672e (lcd: refactor lcd console stuff into its
> own file), which cause lcd console address is not initialized.
> 
> This patch initialize the lcd console use the default value,
> will be update when splash screen is enabled.
> 
> Signed-off-by: Bo Shen <voice.shen@atmel.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/common/lcd.c b/common/lcd.c
index cc34b8a..1195a54 100644
--- a/common/lcd.c
+++ b/common/lcd.c
@@ -268,6 +268,7 @@  void lcd_clear(void)
 	console_rows = panel_info.vl_row / VIDEO_FONT_HEIGHT;
 #endif
 	console_cols = panel_info.vl_col / VIDEO_FONT_WIDTH;
+	lcd_init_console(lcd_base, console_rows, console_cols);
 	lcd_init_console(lcd_logo(), console_rows, console_cols);
 	lcd_sync();
 }