diff mbox

[U-Boot,07/10,v6] lib/rsa: Add Kconfig for devices supporting RSA Modular Exponentiation

Message ID 1422009119-533-7-git-send-email-ruchika.gupta@freescale.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Ruchika Gupta Jan. 23, 2015, 10:31 a.m. UTC
Kconfig option added for devices which support RSA Verification.
1. RSA_SOFTWARE_EXP
Enables driver for supporting RSA Modular Exponentiation in Software
2. RSA_FREESCALE_EXP
Enables driver for supporting RSA Modular Exponentiation using Freescale specific
driver

The above drivers use RSA uclass

Signed-off-by: Ruchika Gupta <ruchika.gupta@freescale.com>
CC: Simon Glass <sjg@chromium.org>
---
Changes in v6:
No Changes

Changes in v5:
No changes

Changes in v4:
Introduced 2 options when CONFIG_RSA is selected:
RSA_SOFTWARE_EXP
RSA_FREESCALE_EXP

Removed RSA_HW. Changes the name pf RSA_SW to RSA_SOFTWARE_EXP

Changes in v3:
New patch
 lib/Kconfig     |  7 +------
 lib/rsa/Kconfig | 28 ++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+), 6 deletions(-)
 create mode 100644 lib/rsa/Kconfig

Comments

Simon Glass Jan. 26, 2015, 1:39 p.m. UTC | #1
On 23 January 2015 at 03:31, Ruchika Gupta <ruchika.gupta@freescale.com> wrote:
> Kconfig option added for devices which support RSA Verification.
> 1. RSA_SOFTWARE_EXP
> Enables driver for supporting RSA Modular Exponentiation in Software
> 2. RSA_FREESCALE_EXP
> Enables driver for supporting RSA Modular Exponentiation using Freescale specific
> driver
>
> The above drivers use RSA uclass
>
> Signed-off-by: Ruchika Gupta <ruchika.gupta@freescale.com>
> CC: Simon Glass <sjg@chromium.org>
> ---
> Changes in v6:
> No Changes
>
> Changes in v5:
> No changes
>
> Changes in v4:
> Introduced 2 options when CONFIG_RSA is selected:
> RSA_SOFTWARE_EXP
> RSA_FREESCALE_EXP
>
> Removed RSA_HW. Changes the name pf RSA_SW to RSA_SOFTWARE_EXP
>
> Changes in v3:
> New patch
>  lib/Kconfig     |  7 +------
>  lib/rsa/Kconfig | 28 ++++++++++++++++++++++++++++
>  2 files changed, 29 insertions(+), 6 deletions(-)
>  create mode 100644 lib/rsa/Kconfig

Acked-by: Simon Glass <sjg@chromium.org>

(note the duplicated line in your Kconfig if you issue a new version,
but I can clean that up when applying it)


+++ b/lib/rsa/Kconfig
> @@ -0,0 +1,28 @@
> +config RSA
> +       bool "Use RSA Library"
> +       select RSA_FREESCALE_EXP if FSL_CAAM
> +       select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP
> +       help
> +         RSA support. This enables the RSA algorithm used for FIT image
> +         verification in U-Boot.
> +         See doc/uImage.FIT/signature.txt for more details.
> +         See doc/uImage.FIT/signature.txt for more details.
Simon Glass Jan. 28, 2015, 8:09 p.m. UTC | #2
On 26 January 2015 at 06:39, Simon Glass <sjg@chromium.org> wrote:
> On 23 January 2015 at 03:31, Ruchika Gupta <ruchika.gupta@freescale.com> wrote:
>> Kconfig option added for devices which support RSA Verification.
>> 1. RSA_SOFTWARE_EXP
>> Enables driver for supporting RSA Modular Exponentiation in Software
>> 2. RSA_FREESCALE_EXP
>> Enables driver for supporting RSA Modular Exponentiation using Freescale specific
>> driver
>>
>> The above drivers use RSA uclass
>>
>> Signed-off-by: Ruchika Gupta <ruchika.gupta@freescale.com>
>> CC: Simon Glass <sjg@chromium.org>
>> ---
>> Changes in v6:
>> No Changes
>>
>> Changes in v5:
>> No changes
>>
>> Changes in v4:
>> Introduced 2 options when CONFIG_RSA is selected:
>> RSA_SOFTWARE_EXP
>> RSA_FREESCALE_EXP
>>
>> Removed RSA_HW. Changes the name pf RSA_SW to RSA_SOFTWARE_EXP
>>
>> Changes in v3:
>> New patch
>>  lib/Kconfig     |  7 +------
>>  lib/rsa/Kconfig | 28 ++++++++++++++++++++++++++++
>>  2 files changed, 29 insertions(+), 6 deletions(-)
>>  create mode 100644 lib/rsa/Kconfig
>
> Acked-by: Simon Glass <sjg@chromium.org>
>
> (note the duplicated line in your Kconfig if you issue a new version,
> but I can clean that up when applying it)
>
>
> +++ b/lib/rsa/Kconfig
>> @@ -0,0 +1,28 @@
>> +config RSA
>> +       bool "Use RSA Library"
>> +       select RSA_FREESCALE_EXP if FSL_CAAM
>> +       select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP
>> +       help
>> +         RSA support. This enables the RSA algorithm used for FIT image
>> +         verification in U-Boot.
>> +         See doc/uImage.FIT/signature.txt for more details.
>> +         See doc/uImage.FIT/signature.txt for more details.

I tidied this up.

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/lib/Kconfig b/lib/Kconfig
index 79b91b7..a1f30a2 100644
--- a/lib/Kconfig
+++ b/lib/Kconfig
@@ -27,11 +27,6 @@  config SYS_HZ
 	  get_timer() must operate in milliseconds and this option must be
 	  set to 1000.
 
-config RSA
-	bool "Use RSA Library"
-	help
-	  RSA support. This enables the RSA algorithm used for FIT image
-	  verification in U-Boot.
-	  See doc/uImage.FIT/signature.txt for more details.
+source lib/rsa/Kconfig
 
 endmenu
diff --git a/lib/rsa/Kconfig b/lib/rsa/Kconfig
new file mode 100644
index 0000000..4fa79d7
--- /dev/null
+++ b/lib/rsa/Kconfig
@@ -0,0 +1,28 @@ 
+config RSA
+	bool "Use RSA Library"
+	select RSA_FREESCALE_EXP if FSL_CAAM
+	select RSA_SOFTWARE_EXP if !RSA_FREESCALE_EXP
+	help
+	  RSA support. This enables the RSA algorithm used for FIT image
+	  verification in U-Boot.
+	  See doc/uImage.FIT/signature.txt for more details.
+	  See doc/uImage.FIT/signature.txt for more details.
+
+if RSA
+config RSA_SOFTWARE_EXP
+	bool "Enable driver for RSA Modular Exponentiation in software"
+	depends on DM && RSA
+	help
+	  Enables driver for modular exponentiation in software. This is a RSA
+	  algorithm used in FIT image verification. It required RSA Key as
+	  input.
+	  See doc/uImage.FIT/signature.txt for more details.
+
+config RSA_FREESCALE_EXP
+	bool "Enable RSA Modular Exponentiation with FSL crypto accelerator"
+	depends on DM && RSA && FSL_CAAM
+	help
+	Enables driver for RSA modular exponentiation using Freescale cryptographic
+	accelerator - CAAM.
+
+endif