| Message ID | 1418092779-20025-1-git-send-email-human.hwang@samsung.com |
|---|---|
| State | Not Applicable |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hyungwon Hwang <human.hwang@samsung.com> writes: > This is v11 of the patchset adding support Odroud XU3 board. I finally got around to testing this on top of v2015.01-rc3 on my XU3. As I mentioned earlier, I had to enable the USB and networking options so I could dhcp/tftp but after that it works for me. Feel free to add: Tested-by: Kevin Hilman <khilman@linaro.org> [...] > Note: If you use micro SD card for your test you have to apply the below > patch additionally. This patch is needed, because micro sd card is > recognized as MMC1 instead of MMC0. Additional work is needed to make it > work regardless of device id. FYI, with or without your MMC ID patch, I wasn't able to save the environment to the SD card I'm booting from: ODROID-XU3 # saveenv Saving Environment to MMC... dwmci_send_cmd: Timeout. MMC init failed Kevin
Dear Kevin, On Tue, 09 Dec 2014 15:36:00 -0800 Kevin Hilman <khilman@kernel.org> wrote: > Hyungwon Hwang <human.hwang@samsung.com> writes: > > > This is v11 of the patchset adding support Odroud XU3 board. > > I finally got around to testing this on top of v2015.01-rc3 on my XU3. > > As I mentioned earlier, I had to enable the USB and networking options > so I could dhcp/tftp but after that it works for me. > > Feel free to add: > > Tested-by: Kevin Hilman <khilman@linaro.org> Thanks for yout review. Sjoerd is waiting for his patch merged (title: Exynos: Move down common USB configuration). So the features related USB and networking will be enabled after this patchset and his patch are merged. > > [...] > > > Note: If you use micro SD card for your test you have to apply the > > below patch additionally. This patch is needed, because micro sd > > card is recognized as MMC1 instead of MMC0. Additional work is > > needed to make it work regardless of device id. > > FYI, with or without your MMC ID patch, I wasn't able to save the > environment to the SD card I'm booting from: > > ODROID-XU3 # saveenv > Saving Environment to MMC... > dwmci_send_cmd: Timeout. > MMC init failed > Actually I just tested it again. But it works for me. Saving Environment to MMC... Writing to MMC(1)... done I applied my patchset and MMC ID patch to commit 38cd8c4253013ccdd4052ee021f6066fe9a52551 in http://git.denx.de/u-boot-samsung.git (branch: master). I don't know why it does't work for you. Please feel free to need my help for this, if you need. > Kevin Best regards, Hyungwon Hwang
Hello Hyungwon Hwang, On Tue, Dec 9, 2014 at 4:58 PM, Hyungwon Hwang <human.hwang@samsung.com> wrote: > Dear Kevin, > > On Tue, 09 Dec 2014 15:36:00 -0800 > Kevin Hilman <khilman@kernel.org> wrote: > >> Hyungwon Hwang <human.hwang@samsung.com> writes: >> >> > This is v11 of the patchset adding support Odroud XU3 board. >> >> I finally got around to testing this on top of v2015.01-rc3 on my XU3. >> >> As I mentioned earlier, I had to enable the USB and networking options >> so I could dhcp/tftp but after that it works for me. >> >> Feel free to add: >> >> Tested-by: Kevin Hilman <khilman@linaro.org> > > Thanks for yout review. Sjoerd is waiting for his patch merged > (title: Exynos: Move down common USB > configuration). So the features related USB and networking will be > enabled after this patchset and his patch are merged. > >> >> [...] >> >> > Note: If you use micro SD card for your test you have to apply the >> > below patch additionally. This patch is needed, because micro sd >> > card is recognized as MMC1 instead of MMC0. Additional work is >> > needed to make it work regardless of device id. >> >> FYI, with or without your MMC ID patch, I wasn't able to save the >> environment to the SD card I'm booting from: >> >> ODROID-XU3 # saveenv >> Saving Environment to MMC... >> dwmci_send_cmd: Timeout. >> MMC init failed >> > > Actually I just tested it again. But it works for me. > > Saving Environment to MMC... > Writing to MMC(1)... done > > I applied my patchset and MMC ID patch to commit > 38cd8c4253013ccdd4052ee021f6066fe9a52551 in > http://git.denx.de/u-boot-samsung.git (branch: master). > > I don't know why it does't work for you. Please feel free to need my > help for this, if you need. > Just like Kevin, I have to say that mmc is erratic. For example, if you let the boot process go all along (and not interrupt it), and let it fail in the pxe load commands. Then if you do a, ls mmc 1:1 / it will give a timeout error (Assuming you do have a valid 1st partition) But, if you interrupt the boot during the count down, and issue the same, it will work. I had mentioned this before, that if you enable *MMC_TRACE, it again stops working. Also, I found if you do a couple of mmc 1:1 commands, and do some other commands (say mmc rescan etc), and retry it will fail. Regards - Suriyan >> Kevin > > Best regards, > Hyungwon Hwang > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot
Dear Suriyan, On Tue, 09 Dec 2014 18:29:56 -0800 Suriyan Ramasami <suriyan.r@gmail.com> wrote: > Hello Hyungwon Hwang, > > On Tue, Dec 9, 2014 at 4:58 PM, Hyungwon Hwang > <human.hwang@samsung.com> wrote: > > Dear Kevin, > > > > On Tue, 09 Dec 2014 15:36:00 -0800 > > Kevin Hilman <khilman@kernel.org> wrote: > > > >> Hyungwon Hwang <human.hwang@samsung.com> writes: > >> > >> > This is v11 of the patchset adding support Odroud XU3 board. > >> > >> I finally got around to testing this on top of v2015.01-rc3 on my > >> XU3. > >> > >> As I mentioned earlier, I had to enable the USB and networking > >> options so I could dhcp/tftp but after that it works for me. > >> > >> Feel free to add: > >> > >> Tested-by: Kevin Hilman <khilman@linaro.org> > > > > Thanks for yout review. Sjoerd is waiting for his patch merged > > (title: Exynos: Move down common USB > > configuration). So the features related USB and networking will be > > enabled after this patchset and his patch are merged. > > > >> > >> [...] > >> > >> > Note: If you use micro SD card for your test you have to apply > >> > the below patch additionally. This patch is needed, because > >> > micro sd card is recognized as MMC1 instead of MMC0. Additional > >> > work is needed to make it work regardless of device id. > >> > >> FYI, with or without your MMC ID patch, I wasn't able to save the > >> environment to the SD card I'm booting from: > >> > >> ODROID-XU3 # saveenv > >> Saving Environment to MMC... > >> dwmci_send_cmd: Timeout. > >> MMC init failed > >> > > > > Actually I just tested it again. But it works for me. > > > > Saving Environment to MMC... > > Writing to MMC(1)... done > > > > I applied my patchset and MMC ID patch to commit > > 38cd8c4253013ccdd4052ee021f6066fe9a52551 in > > http://git.denx.de/u-boot-samsung.git (branch: master). > > > > I don't know why it does't work for you. Please feel free to need my > > help for this, if you need. > > > > Just like Kevin, I have to say that mmc is erratic. > For example, if you let the boot process go all along (and not > interrupt it), and let it fail in the pxe load commands. Then if you > do a, ls mmc 1:1 / it will give a timeout error (Assuming you do have > a valid 1st partition) > But, if you interrupt the boot during the count down, and issue the > same, it will work. > I had mentioned this before, that if you enable *MMC_TRACE, it again > stops working. > > Also, I found if you do a couple of mmc 1:1 commands, and do some > other commands (say mmc rescan etc), and retry it will fail. I tested all sinarios that you told me. But in all cases, it works for me. That's awkward. You are using Micro SD card. Right? > > Regards > - Suriyan > > > >> Kevin > > > > Best regards, > > Hyungwon Hwang > > _______________________________________________ > > U-Boot mailing list > > U-Boot@lists.denx.de > > http://lists.denx.de/mailman/listinfo/u-boot Best regards, Hyungwon Hwang
Hello Hyungwon Hwang, On Tue, Dec 9, 2014 at 7:52 PM, Hyungwon Hwang <human.hwang@samsung.com> wrote: > Dear Suriyan, > > On Tue, 09 Dec 2014 18:29:56 -0800 > Suriyan Ramasami <suriyan.r@gmail.com> wrote: > >> Hello Hyungwon Hwang, >> >> On Tue, Dec 9, 2014 at 4:58 PM, Hyungwon Hwang >> <human.hwang@samsung.com> wrote: >> > Dear Kevin, >> > >> > On Tue, 09 Dec 2014 15:36:00 -0800 >> > Kevin Hilman <khilman@kernel.org> wrote: >> > >> >> Hyungwon Hwang <human.hwang@samsung.com> writes: >> >> >> >> > This is v11 of the patchset adding support Odroud XU3 board. >> >> >> >> I finally got around to testing this on top of v2015.01-rc3 on my >> >> XU3. >> >> >> >> As I mentioned earlier, I had to enable the USB and networking >> >> options so I could dhcp/tftp but after that it works for me. >> >> >> >> Feel free to add: >> >> >> >> Tested-by: Kevin Hilman <khilman@linaro.org> >> > >> > Thanks for yout review. Sjoerd is waiting for his patch merged >> > (title: Exynos: Move down common USB >> > configuration). So the features related USB and networking will be >> > enabled after this patchset and his patch are merged. >> > >> >> >> >> [...] >> >> >> >> > Note: If you use micro SD card for your test you have to apply >> >> > the below patch additionally. This patch is needed, because >> >> > micro sd card is recognized as MMC1 instead of MMC0. Additional >> >> > work is needed to make it work regardless of device id. >> >> >> >> FYI, with or without your MMC ID patch, I wasn't able to save the >> >> environment to the SD card I'm booting from: >> >> >> >> ODROID-XU3 # saveenv >> >> Saving Environment to MMC... >> >> dwmci_send_cmd: Timeout. >> >> MMC init failed >> >> >> > >> > Actually I just tested it again. But it works for me. >> > >> > Saving Environment to MMC... >> > Writing to MMC(1)... done >> > >> > I applied my patchset and MMC ID patch to commit >> > 38cd8c4253013ccdd4052ee021f6066fe9a52551 in >> > http://git.denx.de/u-boot-samsung.git (branch: master). >> > >> > I don't know why it does't work for you. Please feel free to need my >> > help for this, if you need. >> > >> >> Just like Kevin, I have to say that mmc is erratic. >> For example, if you let the boot process go all along (and not >> interrupt it), and let it fail in the pxe load commands. Then if you >> do a, ls mmc 1:1 / it will give a timeout error (Assuming you do have >> a valid 1st partition) >> But, if you interrupt the boot during the count down, and issue the >> same, it will work. >> I had mentioned this before, that if you enable *MMC_TRACE, it again >> stops working. >> >> Also, I found if you do a couple of mmc 1:1 commands, and do some >> other commands (say mmc rescan etc), and retry it will fail. > > I tested all sinarios that you told me. But in all cases, it works for > me. That's awkward. You are using Micro SD card. Right? > Yes, I am using the Micro SD card. I shall use a different cross compiling tool chain, or, come with a test case which is consistent (by tomorrow). Cheers! - Suriyan >> >> Regards >> - Suriyan >> >> >> >> Kevin >> > >> > Best regards, >> > Hyungwon Hwang >> > _______________________________________________ >> > U-Boot mailing list >> > U-Boot@lists.denx.de >> > http://lists.denx.de/mailman/listinfo/u-boot > > Best regards, > Hyungwon Hwang
Hyungwon Hwang <human.hwang@samsung.com> writes: > Dear Kevin, > > On Tue, 09 Dec 2014 15:36:00 -0800 > Kevin Hilman <khilman@kernel.org> wrote: > >> Hyungwon Hwang <human.hwang@samsung.com> writes: >> >> > This is v11 of the patchset adding support Odroud XU3 board. >> >> I finally got around to testing this on top of v2015.01-rc3 on my XU3. >> >> As I mentioned earlier, I had to enable the USB and networking options >> so I could dhcp/tftp but after that it works for me. >> >> Feel free to add: >> >> Tested-by: Kevin Hilman <khilman@linaro.org> > > Thanks for yout review. Sjoerd is waiting for his patch merged > (title: Exynos: Move down common USB > configuration). So the features related USB and networking will be > enabled after this patchset and his patch are merged. OK, good. >> >> [...] >> >> > Note: If you use micro SD card for your test you have to apply the >> > below patch additionally. This patch is needed, because micro sd >> > card is recognized as MMC1 instead of MMC0. Additional work is >> > needed to make it work regardless of device id. >> >> FYI, with or without your MMC ID patch, I wasn't able to save the >> environment to the SD card I'm booting from: >> >> ODROID-XU3 # saveenv >> Saving Environment to MMC... >> dwmci_send_cmd: Timeout. >> MMC init failed >> > > Actually I just tested it again. But it works for me. > > Saving Environment to MMC... > Writing to MMC(1)... done > > I applied my patchset and MMC ID patch to commit > 38cd8c4253013ccdd4052ee021f6066fe9a52551 in > http://git.denx.de/u-boot-samsung.git (branch: master). > > I don't know why it does't work for you. Please feel free to need my > help for this, if you need. Curious wh you're using u-boot-samsung.git and not mainline. Can you test this using mainline u-boot v2015.01-rc3? Kevin
On Wed, 10 Dec 2014 11:23:08 -0800 Kevin Hilman <khilman@kernel.org> wrote: > Hyungwon Hwang <human.hwang@samsung.com> writes: > > > Dear Kevin, > > > > On Tue, 09 Dec 2014 15:36:00 -0800 > > Kevin Hilman <khilman@kernel.org> wrote: > > > >> Hyungwon Hwang <human.hwang@samsung.com> writes: > >> > >> > This is v11 of the patchset adding support Odroud XU3 board. > >> > >> I finally got around to testing this on top of v2015.01-rc3 on my > >> XU3. > >> > >> As I mentioned earlier, I had to enable the USB and networking > >> options so I could dhcp/tftp but after that it works for me. > >> > >> Feel free to add: > >> > >> Tested-by: Kevin Hilman <khilman@linaro.org> > > > > Thanks for yout review. Sjoerd is waiting for his patch merged > > (title: Exynos: Move down common USB > > configuration). So the features related USB and networking will be > > enabled after this patchset and his patch are merged. > > OK, good. > > >> > >> [...] > >> > >> > Note: If you use micro SD card for your test you have to apply > >> > the below patch additionally. This patch is needed, because > >> > micro sd card is recognized as MMC1 instead of MMC0. Additional > >> > work is needed to make it work regardless of device id. > >> > >> FYI, with or without your MMC ID patch, I wasn't able to save the > >> environment to the SD card I'm booting from: > >> > >> ODROID-XU3 # saveenv > >> Saving Environment to MMC... > >> dwmci_send_cmd: Timeout. > >> MMC init failed > >> > > > > Actually I just tested it again. But it works for me. > > > > Saving Environment to MMC... > > Writing to MMC(1)... done > > > > I applied my patchset and MMC ID patch to commit > > 38cd8c4253013ccdd4052ee021f6066fe9a52551 in > > http://git.denx.de/u-boot-samsung.git (branch: master). > > > > I don't know why it does't work for you. Please feel free to need my > > help for this, if you need. > > Curious wh you're using u-boot-samsung.git and not mainline. Can you > test this using mainline u-boot v2015.01-rc3? > > Kevin >
Dear Kevin, On Wed, 10 Dec 2014 11:23:08 -0800 Kevin Hilman <khilman@kernel.org> wrote: > Hyungwon Hwang <human.hwang@samsung.com> writes: > > > Dear Kevin, > > > > On Tue, 09 Dec 2014 15:36:00 -0800 > > Kevin Hilman <khilman@kernel.org> wrote: > > > >> Hyungwon Hwang <human.hwang@samsung.com> writes: > >> > >> > This is v11 of the patchset adding support Odroud XU3 board. > >> > >> I finally got around to testing this on top of v2015.01-rc3 on my > >> XU3. > >> > >> As I mentioned earlier, I had to enable the USB and networking > >> options so I could dhcp/tftp but after that it works for me. > >> > >> Feel free to add: > >> > >> Tested-by: Kevin Hilman <khilman@linaro.org> > > > > Thanks for yout review. Sjoerd is waiting for his patch merged > > (title: Exynos: Move down common USB > > configuration). So the features related USB and networking will be > > enabled after this patchset and his patch are merged. > > OK, good. > > >> > >> [...] > >> > >> > Note: If you use micro SD card for your test you have to apply > >> > the below patch additionally. This patch is needed, because > >> > micro sd card is recognized as MMC1 instead of MMC0. Additional > >> > work is needed to make it work regardless of device id. > >> > >> FYI, with or without your MMC ID patch, I wasn't able to save the > >> environment to the SD card I'm booting from: > >> > >> ODROID-XU3 # saveenv > >> Saving Environment to MMC... > >> dwmci_send_cmd: Timeout. > >> MMC init failed > >> > > > > Actually I just tested it again. But it works for me. > > > > Saving Environment to MMC... > > Writing to MMC(1)... done > > > > I applied my patchset and MMC ID patch to commit > > 38cd8c4253013ccdd4052ee021f6066fe9a52551 in > > http://git.denx.de/u-boot-samsung.git (branch: master). > > > > I don't know why it does't work for you. Please feel free to need my > > help for this, if you need. > > Curious wh you're using u-boot-samsung.git and not mainline. Can you > test this using mainline u-boot v2015.01-rc3? I am sorry for the previous email. It was sent mistakenly by the bug of pressing ctrl in my multi-screen program. As I know, basically the merge is done by Minkyu Kang who manages the u-boot-samsung, and he send pull request to mainline. So I have done this work based on u-boot-samsung. How about use u-boot-samsung until it is merged to mainline, even though there is a explicit bug (You can fix it with https://patchwork.ozlabs.org/patch/415635/)? Also, I tested saveenv in the mainline u-boot(http://git.denx.de/u-boot.git). But it works. Which compiler do you use? I use gcc version 4.8.2 (Ubuntu/Linaro 4.8.2-16ubuntu4). Can you tell me what you use or test it using another compiler? > > Kevin >
diff --git a/include/configs/exynos5-common.h b/include/configs/exynos5-common.h index ba591e7..437eaae 100644 --- a/include/configs/exynos5-common.h +++ b/include/configs/exynos5-common.h @@ -109,7 +109,7 @@ #define CONFIG_SYS_MONITOR_BASE 0x00000000 -#define CONFIG_SYS_MMC_ENV_DEV 0 +#define CONFIG_SYS_MMC_ENV_DEV 1 #define CONFIG_SECURE_BL1_ONLY