| Message ID | 1417504034-25522-5-git-send-email-human.hwang@samsung.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Minkyu Kang |
| Headers | show |
Hi, On 2 December 2014 at 00:07, Hyungwon Hwang <human.hwang@samsung.com> wrote: > From: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > > Add samsung,vbus-gpio information for the XU3. This allows the usage of > the EHCI controller on the XU3, which is connected to the SMSC LAN9514 > chip (usb hub + network). > > Note that this patch doesn't enable support for USB/USB networking in > the default config as makes the u-boot binary too big for the current odroid > setup. > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> > Cc: Minkyu Kang <mk7.kang@samsung.com> > Cc: Lukasz Majewski <l.majewski@samsung.com> > Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > Cc: Javier Martinez Canillas <javier@dowhile0.org> > Cc: Simon Glass <sjg@chromium.org> > --- > Changes for v10: > - Newly added > > arch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts b/arch/arm/dts/exynos5422-odroidxu3.dts > index cff32a9..be20f1b 100644 > --- a/arch/arm/dts/exynos5422-odroidxu3.dts > +++ b/arch/arm/dts/exynos5422-odroidxu3.dts > @@ -31,6 +31,10 @@ > 0xb0000000 0xea00000>; > }; > > + ehci@12110000 { > + samsung,vbus-gpio = <&gpio 0x316 0>; /* X26 */ Are you sure this is right? By my count this should be 0x66, not 0x316. This might be historical. It almost feels like you could drop this patch until you actually have working USB support. Regards, Simon
+ajaykumar On Tue, 2014-12-02 at 10:25 -0700, Simon Glass wrote: > Hi, > > On 2 December 2014 at 00:07, Hyungwon Hwang <human.hwang@samsung.com> wrote: > > From: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > > > > Add samsung,vbus-gpio information for the XU3. This allows the usage of > > the EHCI controller on the XU3, which is connected to the SMSC LAN9514 > > chip (usb hub + network). > > > > Note that this patch doesn't enable support for USB/USB networking in > > the default config as makes the u-boot binary too big for the current odroid > > setup. > > > > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > > Signed-off-by: Hyungwon Hwang <human.hwang@samsung.com> > > Cc: Minkyu Kang <mk7.kang@samsung.com> > > Cc: Lukasz Majewski <l.majewski@samsung.com> > > Cc: Sjoerd Simons <sjoerd.simons@collabora.co.uk> > > Cc: Javier Martinez Canillas <javier@dowhile0.org> > > Cc: Simon Glass <sjg@chromium.org> > > --- > > Changes for v10: > > - Newly added > > > > arch/arm/dts/exynos5422-odroidxu3.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts b/arch/arm/dts/exynos5422-odroidxu3.dts > > index cff32a9..be20f1b 100644 > > --- a/arch/arm/dts/exynos5422-odroidxu3.dts > > +++ b/arch/arm/dts/exynos5422-odroidxu3.dts > > @@ -31,6 +31,10 @@ > > 0xb0000000 0xea00000>; > > }; > > > > + ehci@12110000 { > > + samsung,vbus-gpio = <&gpio 0x316 0>; /* X26 */ > > Are you sure this is right? By my count this should be 0x66, not > 0x316. This might be historical. Yes you're right! I copied the number from the exynos5250-smdk5250.dts without double-checking (even though i fixed the exact same isseu for snow recently, doh). Please drop this patch from the set for now, and i'll send an updated one seperately. But that shouldn't block merging the other patches in this set. > It almost feels like you could drop this patch until you actually have > working USB support. USB does work, but it turns out that's because board_usb_vbus_init in smdk5420 hardcodes turning on GPIO X26 (which happens to be correct for XU3).. Which interestingly collides with exynos_lcd_power_on which hardcodes using GPIO X26 for the EDP_HPD (as used on the snow/peach boards). So looks like some more things to fix :)
diff --git a/arch/arm/dts/exynos5422-odroidxu3.dts b/arch/arm/dts/exynos5422-odroidxu3.dts index cff32a9..be20f1b 100644 --- a/arch/arm/dts/exynos5422-odroidxu3.dts +++ b/arch/arm/dts/exynos5422-odroidxu3.dts @@ -31,6 +31,10 @@ 0xb0000000 0xea00000>; }; + ehci@12110000 { + samsung,vbus-gpio = <&gpio 0x316 0>; /* X26 */ + }; + serial@12C20000 { status="okay"; };