| Message ID | 1415278985-8482-4-git-send-email-wd@denx.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Marek Vasut |
| Headers | show |
On Thursday, November 06, 2014 at 02:02:59 PM, Wolfgang Denk wrote: > Fix error detected by cppcheck: > > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: ''. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'ISP116X_HCD_OC_ENABLE'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: > 'ISP116X_HCD_REMOTE_WAKEUP_ENABLE'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'ISP116X_HCD_SEL15kRES'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: > 'ISP116X_HCD_USE_EXTRA_DELAY'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'ISP116X_HCD_USE_UDELAY'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'TRACE'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'TRACE;VERBOSE'. > [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of > character (() when these macros are defined: 'VERBOSE'. > > Signed-off-by: Wolfgang Denk <wd@denx.de> > Cc: Stephen Warren <swarren@wwwdotorg.org> > Cc: Marek Vasut <marex@denx.de> A brief grep: marex@bfu:u-boot$ git grep USB_ISP116X_HCD drivers/usb/host/Makefile:obj-$(CONFIG_USB_ISP116X_HCD) += isp116x-hcd.o include/usb.h: defined(CONFIG_USB_SL811HS) || defined(CONFIG_USB_ISP116X_HCD) || \ marex@bfu:u-boot$ gives me a better idea on how to resolve this bug ... scrap this code altogether. Looks like the code was unused forever. Can you prepare a patch for that please ? Best regards, Marek Vasut
diff --git a/drivers/usb/host/isp116x-hcd.c b/drivers/usb/host/isp116x-hcd.c index 46e4cee..35d4e9f 100644 --- a/drivers/usb/host/isp116x-hcd.c +++ b/drivers/usb/host/isp116x-hcd.c @@ -1279,7 +1279,7 @@ int isp116x_check_id(struct isp116x *isp116x) return 0; } -int usb_lowlevel_init(int index, enum usb_init_type init, void **controller)) +int usb_lowlevel_init(int index, enum usb_init_type init, void **controller) { struct isp116x *isp116x = &isp116x_dev;
Fix error detected by cppcheck: [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: ''. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_OC_ENABLE'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_REMOTE_WAKEUP_ENABLE'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_SEL15kRES'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_USE_EXTRA_DELAY'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'ISP116X_HCD_USE_UDELAY'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'TRACE'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'TRACE;VERBOSE'. [drivers/usb/host/isp116x-hcd.c:1282]: (error) Invalid number of character (() when these macros are defined: 'VERBOSE'. Signed-off-by: Wolfgang Denk <wd@denx.de> Cc: Stephen Warren <swarren@wwwdotorg.org> Cc: Marek Vasut <marex@denx.de> --- drivers/usb/host/isp116x-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)