diff mbox

[U-Boot,2/9] board/cogent/lcd.c: fix syntax error

Message ID 1415278985-8482-3-git-send-email-wd@denx.de
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Wolfgang Denk Nov. 6, 2014, 1:02 p.m. UTC 
Fix error detected by cppcheck:

[board/cogent/lcd.c:237]: (error) Invalid number of character (()
when these macros are defined:
'CONFIG_SHOW_ACTIVITY;CONFIG_STATUS_LED'.

Signed-off-by: Wolfgang Denk <wd@denx.de>
---
 board/cogent/lcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Nov. 10, 2014, 9:28 p.m. UTC | #1 
On Thu, Nov 06, 2014 at 02:02:58PM +0100, Wolfgang Denk wrote:

> Fix error detected by cppcheck:
> 
> [board/cogent/lcd.c:237]: (error) Invalid number of character (()
> when these macros are defined:
> 'CONFIG_SHOW_ACTIVITY;CONFIG_STATUS_LED'.
> 
> Signed-off-by: Wolfgang Denk <wd@denx.de>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/board/cogent/lcd.c b/board/cogent/lcd.c
index 8e90f98..05ffc4d 100644
--- a/board/cogent/lcd.c
+++ b/board/cogent/lcd.c
@@ -234,7 +234,7 @@  lcd_heartbeat(void)
 void board_show_activity (ulong timestamp)
 {
 #ifdef CONFIG_STATUS_LED
-	if ((timestamp % (CONFIG_SYS_HZ / 2) == 0)
+	if ((timestamp % (CONFIG_SYS_HZ / 2)) == 0)
 		lcd_heartbeat ();
 #endif
 }